From 204c4a41e8f6cfd81b6384bd9f647ae4b714dee3 Mon Sep 17 00:00:00 2001 From: MelekTaus Date: Fri, 9 Oct 2026 09:52:22 +0200 Subject: [PATCH] Expect the Master routing tab and menu entry in e2e 38 and 46 (#351) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CI task 590 for 0e73fd8 (#351) was red in two checks that did not know the new Master routing yet. The product is right, the checks were behind. - e2e 38: the routing tab, opened by e2e 34 in the same run, is a document and may sit behind the plugin tab. The check now accepts every kind of document there, not only lists and assets. - e2e 46: the menu lists "Master routing" after "Project settings…". Tests: - e2e 38 + 46 (melektaus-atx): ALL PASSED, 48 checks. - Counter-probe: CI task 590, the old expectations were red in exactly these two checks. Co-Authored-By: Claude Opus 5.5 --- tools/e2e/38-plugins.mjs | 5 +++-- tools/e2e/46-topbar.mjs | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/e2e/38-plugins.mjs b/tools/e2e/38-plugins.mjs index 48488f62..2a6548b8 100644 --- a/tools/e2e/38-plugins.mjs +++ b/tools/e2e/38-plugins.mjs @@ -39,14 +39,15 @@ export async function plugins(t) { ); // 38b. Its tab sits after the fixed ones and ahead of the open documents (#171) – in the row or - // behind », depending on the width. + // behind », depending on the width. Master routing (#351) is a document too. const { order } = await json('__gm.tabRow()'); const at = order.indexOf('plugin:assets'); + const isDocument = (tab) => ['list', 'routing', 'management'].includes(tab) || tab.startsWith('asset:'); check('the plugin tab is in the tab row', at >= 0, JSON.stringify(order)); check( 'and it comes after the fixed tabs, ahead of any document', JSON.stringify(order.slice(0, 2)) === JSON.stringify(['scene', 'game']) && - order.slice(at + 1).every((tab) => tab === 'list' || tab.startsWith('asset:')), + order.slice(at + 1).every(isDocument), JSON.stringify(order), ); diff --git a/tools/e2e/46-topbar.mjs b/tools/e2e/46-topbar.mjs index 3304d908..2458f768 100644 --- a/tools/e2e/46-topbar.mjs +++ b/tools/e2e/46-topbar.mjs @@ -58,13 +58,14 @@ export async function topbar(t) { 'Snapshots…', 'Release…', 'Project settings…', + 'Master routing', 'Clear saved data', null, 'General settings…', 'Plugins', ]; check( - 'the menu button opens new project, the project picker, the settings, clearing saves, the general settings and the plugins', + 'the menu button opens new project, the project picker, the settings, the master routing, clearing saves, the general settings and the plugins', JSON.stringify(rows) === JSON.stringify(expected), JSON.stringify(rows), );