Show a Limiter node as a device that holds what it took away (#397)
A Limiter only said what it does in rows of numbers. How much it took away, and when, could not be seen at all, and a short sound is over before any needle could show it. Now the node is a device of its own size, and its screen catches the reduction from the moment a sound starts and holds it once the sound ends. - LimiterPanel draws a 720x280 plate of brushed brick. The threshold knob is large, ceiling and release are small beside it, auto-gain is a lever. A LIMIT lamp lights while it takes something away. - The screen hangs the reduction down from the top, 0 to 24 dB by the square root like the Compressor's meter. The level coming in runs along the bottom, orange above the limit. Time runs from the start of the sound over 1, 2, 4 or 8 s, and a longer sound rolls. - ReductionCapture in limiterView holds the capture after 0.4 s of silence, without the silence, until the next sound. It writes the most taken away and when, and NOW or LASTED on the right. - The Limiter is tapped now, like the Compressor. The face reads the loudest sample since the last frame on both sides. - SpectrumTaps.levels takes a lateBy. The side in front is read 5 ms earlier, so a peak going in is met by what it became. - limiterReduction leaves the auto-gain out and solves Wet's blend for the limited part. Less than 0.2 dB counts as none. - A capture is also held when the node leaves the picture. Changing a knob or the lever leaves it as it is. - Hook __gm.limiter.panel(id) for the sound FX and instrument graphs. Decided myself: - The capture stays held until the next sound, not for a fixed time. - The screen has no wet knob, as the Compressor's has none. - The Limiter's two taps cost two gains of 1 per voice. The analysers only exist while the node is in the picture. Measured on stein2: the seeded blip at -4.4 dBFS against -12 dB showed 7.56 dB. Three hits at 0, -8 and -2 dBFS showed 11.9 dB at the first. In e2e 34 on melektaus-atx, -10.44 dBFS in against -20 dB showed 9.56 dB, the difference to the hundredth. Tests: - Unit: limiter-view 13 tests (new), spectrum 6 (1 new), soundfx 67 with the Limiter's taps. - Counter-test: without Wet's share in the formula the blend test fails. - e2e 34: ALL PASSED, 138 checks (1 new). - Gate: CHECK EXIT 0, 290 files, 4445 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
80b25488ce
commit
28909f0adf
13 files changed
+1106
-21
No files matched your search
@@ -459,13 +459,13 @@ describe('a Compressor and a Limiter in a sound FX graph (#326)', () => {
|
||||
(s) => s.kind !== 'tap',
|
||||
);
|
||||
|
||||
it('tap a Compressor on both sides for its tab, a Limiter not (#378)', () => {
|
||||
it('tap a Compressor on both sides for its tab (#378), a Limiter for its screen (#397)', () => {
|
||||
const kinds = (type: string) =>
|
||||
fxChainOf(compileSoundFx(line([{ type }]).fx.graph).compiled!).stages.map((s) =>
|
||||
s.kind === 'tap' ? `tap ${s.at}` : s.kind,
|
||||
);
|
||||
expect(kinds('SoundFxCompressor')).toEqual(['tap in', 'compress', 'tap out']);
|
||||
expect(kinds('SoundFxLimiter')).toEqual(['limit']);
|
||||
expect(kinds('SoundFxLimiter')).toEqual(['tap in', 'limit', 'tap out']);
|
||||
});
|
||||
|
||||
it('compress at their defaults, the gain after it worked out from makeup and auto-gain', () => {
|
||||
@@ -729,7 +729,9 @@ describe('Bypass and Wet (#354)', () => {
|
||||
});
|
||||
|
||||
it('a blend is as late as what it blends and rings as long', () => {
|
||||
const [limit] = fxChainOf({ pitch: [], stages: stagesOf('SoundFxLimiter', { wet: 0.5 }) }).stages;
|
||||
const [limit] = fxChainOf({ pitch: [], stages: stagesOf('SoundFxLimiter', { wet: 0.5 }) }).stages.filter(
|
||||
(s) => s.kind !== 'tap',
|
||||
);
|
||||
expect(limit).toMatchObject({ kind: 'wet' });
|
||||
expect(stageLatency(limit!, 48000)).toBe(0.005);
|
||||
expect(fxRings({ pitch: [], stages: stagesOf('SoundFxLimiter', { wet: 0.5 }) })).toBe(true);
|
||||
|
||||
Reference in new issue
Block a user