A graph that grew past one screen needs somewhere to say what a part of it is for (#38)
game-maker / suite (push) Successful in 6m13s
game-maker / suite (push) Successful in 6m13s
The graph could hold any number of nodes and said nothing about which of them belonged together. Groups and comments are two separate things, as decided in the issue: a group is a titled box that carries the nodes it encloses, a comment is free text that carries nothing. Both live as optional arrays on Graph, not as registry nodes. A comment that were a real node would run through the interpreter, show up in the drop palettes and be compiled into a shader — the wrong place for a piece of text. As arrays on Graph they exist in all four graph kinds at once, and a document without them means exactly "no groups", so no format bump. Membership is computed when the box is grabbed, never stored: the center of a node inside the box travels with it, and a node dragged out is simply out. A box inside a box travels with the outer one, its own nodes included. A group is grabbed by its title bar only — its body stays transparent to the pointer, or a rubber band could never be drawn across the nodes it holds. Deleting a box deletes the box; the nodes stay where they are, because a box that silently took ten nodes with it would be the most expensive surprise in the feature. The color is a free picker, and the title color follows from it: relative luminance per WCAG, threshold at 0.179 where the two contrast ratios meet — not 0.5, which would pick white on mid grey where black reads better. Resizing snaps the far edge to the grid, not the width, so the corner that is not being dragged stays put. The minimum size rises in whole steps for that reason: 80 is no multiple of 24, so a box squeezed to the stop would have sat off-grid in exactly the mode meant to keep it on. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
1135205d69
commit
b9f1a9d319
21 files changed
+1473
-22
No files matched your search
@@ -1,7 +1,11 @@
|
||||
// Importing the graph package index is what registers the built-in nodes.
|
||||
import {
|
||||
ANNOTATION_KINDS,
|
||||
annotationList,
|
||||
createEmptyGraph,
|
||||
type DeclaredPort,
|
||||
type GraphAnnotation,
|
||||
MIN_ANNOTATION_SIZE,
|
||||
type DeclaredPortKind,
|
||||
type Graph,
|
||||
type GraphEdge,
|
||||
@@ -369,9 +373,40 @@ function normalizeGraph(raw: unknown, keep?: (def: NodeDef) => boolean): Graph {
|
||||
if (label) edge.label = label;
|
||||
graph.edges.push(edge);
|
||||
}
|
||||
for (const kind of ANNOTATION_KINDS) {
|
||||
const list = normalizeAnnotations(g[kind === 'group' ? 'groups' : 'notes'], nodeIds);
|
||||
if (list.length > 0) annotationList(graph, kind).push(...list);
|
||||
}
|
||||
return graph;
|
||||
}
|
||||
|
||||
/**
|
||||
* Annotations share the id space with nodes and with each other: a duplicate would make one
|
||||
* selection mean two boxes. A size below the minimum is raised rather than dropped – a box nobody
|
||||
* can see is worse than one that is a little larger than it was written.
|
||||
*/
|
||||
function normalizeAnnotations(raw: unknown, takenIds: Set<string>): GraphAnnotation[] {
|
||||
const list: GraphAnnotation[] = [];
|
||||
for (const item of Array.isArray(raw) ? raw : []) {
|
||||
const a = asRecord(item);
|
||||
const id = typeof a.id === 'string' ? a.id : '';
|
||||
if (!id || takenIds.has(id)) continue;
|
||||
takenIds.add(id);
|
||||
const annotation: GraphAnnotation = {
|
||||
id,
|
||||
x: toNumber(a.x),
|
||||
y: toNumber(a.y),
|
||||
w: Math.max(toNumber(a.w), MIN_ANNOTATION_SIZE.w),
|
||||
h: Math.max(toNumber(a.h), MIN_ANNOTATION_SIZE.h),
|
||||
text: typeof a.text === 'string' ? a.text : '',
|
||||
};
|
||||
if (typeof a.color === 'number' && Number.isFinite(a.color))
|
||||
annotation.color = Math.max(0, Math.min(0xffffff, Math.floor(a.color)));
|
||||
list.push(annotation);
|
||||
}
|
||||
return list;
|
||||
}
|
||||
|
||||
/**
|
||||
* A file name that is not the server's content-addressed form is dropped: a request built from it
|
||||
* would 404, and the texture then loads as "no picture".
|
||||
|
||||
Reference in new issue
Block a user