A graph that grew past one screen needs somewhere to say what a part of it is for (#38)
game-maker / suite (push) Successful in 6m13s

The graph could hold any number of nodes and said nothing about which of them
belonged together. Groups and comments are two separate things, as decided in
the issue: a group is a titled box that carries the nodes it encloses, a
comment is free text that carries nothing.

Both live as optional arrays on Graph, not as registry nodes. A comment that
were a real node would run through the interpreter, show up in the drop
palettes and be compiled into a shader — the wrong place for a piece of text.
As arrays on Graph they exist in all four graph kinds at once, and a document
without them means exactly "no groups", so no format bump.

Membership is computed when the box is grabbed, never stored: the center of a
node inside the box travels with it, and a node dragged out is simply out. A
box inside a box travels with the outer one, its own nodes included. A group
is grabbed by its title bar only — its body stays transparent to the pointer,
or a rubber band could never be drawn across the nodes it holds. Deleting a
box deletes the box; the nodes stay where they are, because a box that
silently took ten nodes with it would be the most expensive surprise in the
feature.

The color is a free picker, and the title color follows from it: relative
luminance per WCAG, threshold at 0.179 where the two contrast ratios meet —
not 0.5, which would pick white on mid grey where black reads better.

Resizing snaps the far edge to the grid, not the width, so the corner that is
not being dragged stays put. The minimum size rises in whole steps for that
reason: 80 is no multiple of 24, so a box squeezed to the stop would have sat
off-grid in exactly the mode meant to keep it on.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
adminandClaude Opus 5 committed 2026-09-16 11:24:34 +02:00
1 parent 1135205d69
commit b9f1a9d319
21 files changed
+1473 -22

No files matched your search

+24 -2
View File
@@ -1,9 +1,10 @@
import type { Command } from '../../core/commands/Command';
import { oneStep } from '../../core/commands/CompoundCommand';
import { CollapseNodesCommand, DisconnectCommand, FoldEdgeCommand } from '../../core/commands/graphCommands';
import type { GraphEdge, GraphNode } from '../../core/graph';
import { annotationNoun } from '../../core/commands/annotationCommands';
import type { AnnotationKind, GraphEdge, GraphNode } from '../../core/graph';
import { Menu, type MenuItem } from '../../ui';
import { removeNodes } from '../actions';
import { removeAnnotation, removeNodes } from '../actions';
import type { EditorState } from '../state';
/** For the selected nodes; a selection mixing both states offers both directions. */
@@ -36,6 +37,27 @@ export function openNodeMenu(
]).open(x, y);
}
/**
* For one group or comment. Only deleting lives here: the title, the text and the colour are
* edited in the inspector, where every other selected thing is edited too.
*/
export function openAnnotationMenu(
state: EditorState,
assetId: string,
kind: AnnotationKind,
id: string,
x: number,
y: number,
): void {
new Menu([
{
label: `Delete ${annotationNoun(kind)}`,
danger: true,
onSelect: () => removeAnnotation(state, assetId, id),
},
]).open(x, y);
}
/**
* The links at one port, or behind one fold mark – the mark is the only handle a hidden link has,
* so it carries the way back. Every entry is one undo step, however many links it covers.