Snap to the grid from the start in every graph tab (#391)
Laying out a graph by hand mostly means lining nodes up, so the magnet was switched on in nearly every session. Every graph tab now starts with it lit: Behavior, State machine, Shader, Particles, Sound FX, Instrument, the song's Routing and the Routing tab. - SnapToggle takes the state it starts in and lights its button to match. GRAPH_SNAPS_AT_FIRST sets it for the toggles and for GraphCanvas alike, so button and canvas cannot disagree. - Curve and Vector Art are no graphs and still start without it. - New hook __gm.graphSnapping(on?) reads every graph tab's magnet, or "mixed" where button and canvas differ, and switches them all. - The e2e harness reads the magnets after each navigate() and then switches them off, as it already sets the zoom transition to 0. Most checks drag a node to an exact spot. e2e 45 does the same itself, because the editor comes up there through the sign-in. - e2e 06 checks that all eight graph tabs started with the magnet on. The checks in 06, 26 and 65 that read it off now say they read what the harness left. Tests: - Unit snap-toggle: 4 tests, 1 new (lit at first, nothing asked of the target before a click). - e2e 06 (melektaus-atx): 150 checks, 1 new. e2e 34: 134 checks. - Gate (melektaus-atx, together with #390): 287 files, 4397 tests. - Pictures looked at: none, the state comes from the hook. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
e70954115c
commit
fe4e0d9f1a
18 files changed
+104
-25
No files matched your search
@@ -4,7 +4,7 @@
|
||||
*/
|
||||
import { beforeAll, describe, expect, it, vi } from 'vitest';
|
||||
import { CanvasTextMetrics } from 'pixi.js';
|
||||
import { SnapToggle } from '../../src/editor/graph/SnapToggle';
|
||||
import { GRAPH_SNAPS_AT_FIRST, SnapToggle } from '../../src/editor/graph/SnapToggle';
|
||||
import { Theme } from '../../src/ui';
|
||||
|
||||
// Node has no DOMParser to read the file with; what the magnet looks like is the icon tests' job.
|
||||
@@ -40,6 +40,20 @@ describe('SnapToggle', () => {
|
||||
expect(canvas.calls).toEqual([true, false]);
|
||||
});
|
||||
|
||||
it('starts lit where its target snaps from the start, as every graph does (#391)', () => {
|
||||
const canvas = target();
|
||||
const snap = new SnapToggle(() => canvas, GRAPH_SNAPS_AT_FIRST);
|
||||
expect(GRAPH_SNAPS_AT_FIRST).toBe(true);
|
||||
expect(snap.button.toggled).toBe(true);
|
||||
expect(snap.snapping).toBe(true);
|
||||
// Nothing is asked of the target before a click: it snaps by itself from the start.
|
||||
expect(canvas.calls).toEqual([]);
|
||||
|
||||
snap.button.onClick?.();
|
||||
expect(snap.button.toggled).toBe(false);
|
||||
expect(canvas.calls).toEqual([false]);
|
||||
});
|
||||
|
||||
it('asks for the target at the click, so a canvas mounted later is the one switched', () => {
|
||||
let canvas = target();
|
||||
const snap = new SnapToggle(() => canvas);
|
||||
|
||||
Reference in new issue
Block a user