5 Commits

Include renames

Author	SHA1	Message	Date
adminandClaude Opus 5.5	ed7872c893	Let a called behavior share the caller's local state machines ... A local state machine started over in every Run behavior call, so a state set in a sub-behavior was gone by the next call. A character controller split into sub-behaviors could therefore never remember that it was attacking. Scene or global scope would keep the state, but then every character shares it. - A call now runs on the states of the instance that runs it, however deep. A state one call sets is still set in the next one, and the call begins in the start state like the instance does. - A move made inside a call is reported like one the caller made. The caller's On state entered and On state exited hear it, the event nodes of the called graph stay silent as before. - Two objects running the same behavior still hold a state each. - This reverses the rule from #229 that local machines of a called behavior are not kept. Keep stays a switch for variables only. Tests: - Two unit tests that pinned the old rule now expect the shared state. - New world test: a sub-behavior closes a door per object, the caller's events hear it, and the next call finds it closed. - Counter-check: with the old call context the 3 tests fail. - Gate on melektaus-atx: 239 files, 3600 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-04 18:38:06 +02:00
adminandClaude Opus 5.5	14972d057f	Refactoring round 8: hide data files, safe saves, Esc as Cancel (#85) ... Recurring cleanup round over the code since round 7 (bc688f3). The issue now also asks to fix bugs and small inconsistencies found on the way, so unlike the rounds before, this one changes behaviour in a few places. Duplicated code in api went from 23 clones with 228 lines to none (jscpd, at least 50 tokens). In src it stays at 22 clones with 271 lines, the same before and after. Bugs: - nginx served project and snapshot files as they were, so anyone who knew a project id could read it without signing in. Every file the API writes now goes through AtomicFile (temp file, mode, rename). Projects, snapshots, releases, accounts and sessions are 0640, and nginx answers 403 for them. - Any signed-in account could delete a shared image, font or sound, which projects of other accounts may wear. Deleting one is now for administrators only. The editor never deleted a file, so the client's delete is gone. - Two saves of one project could run at once. The lock file was removed after each save, so a waiting save and the next one locked different files. The lock file now stays, and deleting a project takes the lock as well. - Bytes that are no picture got a 500 instead of a 422, because the error handler also threw for warnings silenced with @. - A session file was rewritten in place. A request reading it at that moment found it empty and was signed out. It is replaced atomically. - Delete did nothing for a shape picked in the vector art list. Delete now goes through removeSelection, one case per kind of selection, and a kind without a case fails the type check. Inconsistencies: - Escape on a question does what its Cancel does. Cancel on "Delete project?" and "Restore snapshot?" leads back to the picker or the list like the other questions did, and so does deleting a project. - Editor texts use American spelling throughout, like the port names: 48 British spellings in 45 lines (colour, centre, initialised). - objectName and groupName replace eleven copies of "own name, else the asset's" and three of "Group". One copy fell back to the object id instead of "?". Duplicates, dead code, comments: - routeFiles serves images, fonts and sounds instead of three copies. HashedFileStore holds what the three stores shared: keeping a file under its hash with its name, listing and deleting. The stores keep only which bytes they take and what a record says. - AtomicFile replaces nine copies of temp file plus rename. - removeShapes is the one way the canvas, the inspector button and Delete take shapes out. - GraphInterpreter.fire was called by tests only. The 54 calls use a helper in tests/helpers.ts now. - FileStore.delete, HttpFileStore.delete and the PluginApi type were unused. A doc comment in actions.ts sat above the wrong function. Checked and left as is: - solidCells is used by tests only. It is the per-cell view before the merge into rectangles, the one place the largest-scale rule shows. - An undo checker ran all 124 commands of the unit tests and compared the project before and after undo. The only differences are empty ports, groups and notes lists where there were none, which the file format drops anyway. Docs: - README: the check sum. - Wiki, own commit: API (admin-only deletes, 422, file modes, lock file), Home (the "Not yet" list named three things that exist), Concepts, Keyboard, Vector art, Architecture and Development, and the 38 characters Gitea flagged as ambiguous on eight pages. - .gitignore: the lock files, and pasted-*.png in any folder, which keeps the screenshot archive out. Tests: - ./check.sh: 195 files, 2817 tests, exit 0 (+2 for the name helpers). - PHP: accounts 52 in the web container and 53 in the CI image with the race test (+2), snapshots 15 (+1), releases 20. - Full e2e run: ALL PASSED, 1586 checks (+6 in 12, 47, 49 and 50). - Smokes jumprun, tetris, actor: 24, 19 and 21 checks. The example project files were restored byte for byte afterwards. - The file stores of HEAD and of this commit give byte-identical output for the live folders and for store, list and delete in a throwaway folder. - Counter-checks, all fail as expected: a 500 for bad bytes fails 12, no admin check fails 49, removing the lock file again loses saves in 3 of 3 runs (151 to 170 of 321), Delete ignoring shapes fails 47, Escape that only closes fails 50, and dropping the shape case fails the type check (TS2366). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-29 18:12:55 +02:00
adminandClaude Opus 5.5	cf6565d108	Start new behavior variables with Keep switched off ... Keep is a choice the author makes per variable. Switching it on for every new variable meant most behaviors carried state across runs that nobody asked for, and the toggle had to be turned off by hand. - AddVariableCommand no longer adds a new variable to keptVariables. Keep is only switched on by hand. - Existing projects are unchanged. Their keptVariables stay as saved. - The comment in Asset.ts describes the new default. - The counter fixture in keep-state.test.ts now keeps count explicitly instead of relying on the old default. Tests: - ./check.sh: 2706 tests, CHECK EXIT 0 - e2e 1, 6, 19: ALL PASSED, 172 checks - 19c-ii expects [] after adding, then ["var1"], [] and ["var1"] after undo, all clicked with the real mouse - Before the fixtures were adjusted, 8 unit tests failed on the new default Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-28 12:02:40 +02:00
adminandClaude Opus 5.5	454d202109	Let each variable of a behavior choose whether calls keep it (#229) ... The first version of #229 put a Keep state switch on the Run behavior node. The user wanted it where the variable is declared instead. Whether a value lives on belongs to the variable, not to every call site. - The node switch keepState is gone again. RunBehavior, CallResult and nested.ts are back to what they were before #229. - BehaviorAsset.keptVariables lists the kept names. It lives on the asset and not in PropertyDef, because that is the schema of every inspector row. - A variable added from now on starts with Keep on. Variables in existing projects start with Keep off, so old projects run unchanged. - SetVariableKeptCommand flips the switch as one undo step. Add, remove and rename carry the list along. Loading drops names that are not declared. - The interpreter keeps only the listed variables, per Run behavior node and per object as before. The others start at their defaults. - Local state machines in a called behavior start empty on every call again, as before #229. Global and scene machines are unchanged. - The inspector shows a Keep button in each variable row of a behavior. Its state is part of the asset signature, so a click redraws the row. Without that the button kept its old look until the inspector was reopened. Found: the project Garden of Sacrifices still has keepState = true on the call Player -> Character Movement. It is ignored now. Direction there predates the switch, so Keep is off until set by hand. Tests: - ./check.sh: 163 files, 2392 tests, CHECK EXIT 0 (before 2388) - tests/core/keep-state.test.ts rewritten, 15 tests - e2e 19: ALL PASSED, 35 checks. 19c-ii now clicks the Keep button of a new variable: on when added, off by a click, on again, off after undo. - Counter-checks, each fails its own test: keep list ignored (2), states kept (1), new variable not kept (8), rename drops the list (1), no Keep button (e2e 19c-ii). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-25 15:50:59 +02:00
adminandClaude Opus 5.5	7c70245c79	Let a nested behavior keep its variables between calls (#229) ... A Run behavior call started with fresh variables every time, so a nested behavior could not count, remember or keep a local state machine across calls. A new "Keep state" switch on the node lets the callee resume where its last call left off. It is off by default, so existing projects run unchanged. - RunBehavior gets the boolean parameter keepState and its node description explains it. - GraphInterpreter keeps the state in keptCalls, keyed by the call path, the chain of Run behavior nodes. Two nodes calling the same behavior each keep their own state. - One interpreter exists per behavior instance, so every object gets its own state without further code. - Local state machines of the callee are kept like its variables. - resumedVariables() matches kept values against today's declarations. A new variable starts at its default, a removed one drops out, and one whose kind changed starts over. - The kept state lives as long as the object in the run. It is not written to save games. Limit: a callee input named keepState collides with the switch. The same already holds for the name behavior, so it is not caught. Tests: - ./check.sh: 163 files, 2388 tests, CHECK EXIT 0 (before 2377) - 10 new unit tests in tests/core/keep-state.test.ts and 1 new node catalog case. - e2e 19: ALL PASSED, 35 checks, with the new check 19c-ii for the checkbox, its click and undo. - Counter probes: ignoring keepState fails 5 tests, state per behavior instead of per node fails 1, dropping the outer path fails 1, skipping the kind check fails 1, and without the node parameter the e2e check fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-25 14:41:17 +02:00