5 Commits

Include renames

Author	SHA1	Message	Date
adminandClaude Opus 5.5	cfd6d7a8df	Lock the server down before the editor goes public (#427) ... The editor is about to be opened to strangers: a post on Reddit and a guest access (#428). nginx served the whole workspace and ran every PHP file in it, the API let anybody guess passwords as fast as they liked, and one account could fill the disk. - nginx (shared web stack, outside this repo, backup in /root/config-backup-20261015/) hands out only the two pages, dist/, public/brand/, the uploads by kind and ending, and api/index.php. Everything else under /feuerwerk/ is a 404. - PHP behind it has display_errors off and no X-Powered-By. Plain HTTP forwards to HTTPS, the API refuses it. - Headers: a Content-Security-Policy without inline code or eval, nosniff, frame-ancestors, HSTS, Referrer-, Permissions-, COOP, CORP. - vite.config.ts writes the same policy into the built pages, so CI runs the whole suite under it. Pixi gets by without eval through pixi.js/unsafe-eval. The page CSS left its inline style for a file. - The harness fails a module for anything the policy refuses, from Chrome's log and from the page's securitypolicyviolation event. - LoginThrottle: five wrong passwords from one address within 15 minutes, and it gets 429 until 15 minutes after the last of them. The address is the last X-Forwarded-For entry, the Brandmauer's own. - Quota: 1 GB per account for uploads, projects and snapshots. Only a write that grows the account is refused (413). Admins have no limit. - A write whose Sec-Fetch-Site says another site is refused (403). - The session cookie carries Secure, nginx passes HTTPS on. - showFailure puts the message in as text, not as HTML. - Every PHP script outside api/ stops unless it runs on the command line. - The video worker sees the checkout read-only and can only write data/videos. No capabilities, 2 GB and 256 processes at most. - tests/php/rights.test.php runs the API under php -S on a scratch directory and asks every route as signed out, owner, stranger and admin. A route named in api/index.php but missing in the matrix fails it. limits.test.php covers the brake and the quota. Findings: - tmp/ was readable from outside, with 79 copies of project files. Closed on 15.10. at 20:02 with chmod 750. The log back to 11.10. shows only our own requests. - Port 8080 is bound on 0.0.0.0, so the LAN could reach nginx past the Brandmauer. Left as it is: the web stack is not this project's. - npm audit finds nothing in what is shipped. Dev tools (vitest, brace-expansion, source-map-js) have advisories, not touched here. Tests: check 313 files / 4843 tests. PHP limits 21, rights 60, accounts 56, snapshots 15, releases 20, files 46 (videos 50/51, no ffmpeg in the web container). e2e on stein2, atx was off: 34+38+41 197/198, the one red check (a click in 41) passes with 41 alone, 27/27. 67 misses frames at 1080p on stein2 with and without this. Path list from outside: 10 served, 26 refused. ZAP baseline against the live site: nothing High or Medium under /feuerwerk/. Counter-checks: rights.test.php without the cross-site guard, the quota, the brake, the admin check of users, or with an undocumented route fails each time. A policy without wasm-unsafe-eval fails e2e 41 with the harness's own CSP line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-15 23:05:32 +02:00
adminandClaude Opus 5.5	043c224cc3	Rename Game Maker to Feuerwerk and serve it at /feuerwerk/ (#422) ... The editor gets a name of its own that fits beside Brandmauer, Glutspeicher and Feuerwehr. This is stage 1, 2 and 4 of #422: the name, the URL and the stored state in the browser. Repository, CI runners, containers and the GAME_MAKER_* variables follow in stage 3. - All paths come from SITE_PATH in src/core/site.ts: the API endpoint, the data folders, the play page and the base in vite.config.ts. A later move is one line instead of fifteen. - The window title, the sign-in screen, the playground and the README say Feuerwerk. The package, __feuerwerkPlay, the take worklet and the writing app in Ogg and Matroska follow. - The session cookie is now feuerwerk_session, so everyone signs in once more. - localStorage keys are now feuerwerk.*. moveOldStoredKeys copies the old game-maker.* keys over on the first start, so settings, panel sizes and save games survive. - tools/ci/serve.sh serves the build under /feuerwerk/. The variable GAME_MAKER_BASE_URL keeps its name until stage 3. Outside the repository, nockal.com/feuerwerk/ is a second symlink to the same tree. nginx sends the bare /game-maker/ folder there with a 301. Everything else under /game-maker/ is still served directly, so shared play links and the API keep working. Finding: when nginx redirects a path without a trailing slash or with a query, the Brandmauer answers with its own 307 to the same URL plus a slash, placed after the query. A play link would lose its token that way, which is why only the bare folder is redirected. Tests: - Gate on melektaus-atx: CHECK EXIT 0, 307 files, 4756 tests (4 new in site.test.ts). - Counter-check: when the migration misses the old prefix, 3 of the 4 new tests fail. - e2e 60 under /feuerwerk/: ALL PASSED, 20 checks. - From outside: /feuerwerk/ 200, /game-maker/ 301, an old play link 200. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-13 13:27:43 +02:00
adminandClaude Opus 5.5	cbda6d64a7	Let only the owner delete a project, not an administrator (#272) ... #179 decided that nobody deletes a project on someone else's behalf. The API still let an administrator do it, because the admin store treated every project as its own. Option A from the issue is now in place: opening, editing, snapshots and release stay open to the administrator, deleting stays with the owner. - Store::delete checks the owner under the save lock and throws NotOwnerException for anyone else. It follows the pattern of StaleRevisionException. - The route answers that with 403 "Only its owner may delete a project". A file without an owner is covered the same way. Non-admins still get 404 for a project that is not theirs. - The editor has no way to delete a foreign project, the project picker lists only one's own. Nothing changes there. - An account that owns projects can no longer be deleted by an administrator at all. Its owner has to delete them first. - e2e 49 deleted the throwaway projects as administrator, both in its sweep and in 49i. It now signs in as the owner for that. 49i checks both answers. Tests: - tests/php/accounts.test.php: 56 checks passed (was 52, one check turned around, five new) - e2e 49: 22 checks passed (was 21), deleteByAdmin 403, deleteByOwner 204 - Gate: 197 files, 2855 tests passed - Counter-checks: without the owner check 4 PHP checks and 49i fail - The e2e total of 1603 is computed (1602 + 1), not measured Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-30 21:13:20 +02:00
adminandClaude Opus 5.5	14972d057f	Refactoring round 8: hide data files, safe saves, Esc as Cancel (#85) ... Recurring cleanup round over the code since round 7 (bc688f3). The issue now also asks to fix bugs and small inconsistencies found on the way, so unlike the rounds before, this one changes behaviour in a few places. Duplicated code in api went from 23 clones with 228 lines to none (jscpd, at least 50 tokens). In src it stays at 22 clones with 271 lines, the same before and after. Bugs: - nginx served project and snapshot files as they were, so anyone who knew a project id could read it without signing in. Every file the API writes now goes through AtomicFile (temp file, mode, rename). Projects, snapshots, releases, accounts and sessions are 0640, and nginx answers 403 for them. - Any signed-in account could delete a shared image, font or sound, which projects of other accounts may wear. Deleting one is now for administrators only. The editor never deleted a file, so the client's delete is gone. - Two saves of one project could run at once. The lock file was removed after each save, so a waiting save and the next one locked different files. The lock file now stays, and deleting a project takes the lock as well. - Bytes that are no picture got a 500 instead of a 422, because the error handler also threw for warnings silenced with @. - A session file was rewritten in place. A request reading it at that moment found it empty and was signed out. It is replaced atomically. - Delete did nothing for a shape picked in the vector art list. Delete now goes through removeSelection, one case per kind of selection, and a kind without a case fails the type check. Inconsistencies: - Escape on a question does what its Cancel does. Cancel on "Delete project?" and "Restore snapshot?" leads back to the picker or the list like the other questions did, and so does deleting a project. - Editor texts use American spelling throughout, like the port names: 48 British spellings in 45 lines (colour, centre, initialised). - objectName and groupName replace eleven copies of "own name, else the asset's" and three of "Group". One copy fell back to the object id instead of "?". Duplicates, dead code, comments: - routeFiles serves images, fonts and sounds instead of three copies. HashedFileStore holds what the three stores shared: keeping a file under its hash with its name, listing and deleting. The stores keep only which bytes they take and what a record says. - AtomicFile replaces nine copies of temp file plus rename. - removeShapes is the one way the canvas, the inspector button and Delete take shapes out. - GraphInterpreter.fire was called by tests only. The 54 calls use a helper in tests/helpers.ts now. - FileStore.delete, HttpFileStore.delete and the PluginApi type were unused. A doc comment in actions.ts sat above the wrong function. Checked and left as is: - solidCells is used by tests only. It is the per-cell view before the merge into rectangles, the one place the largest-scale rule shows. - An undo checker ran all 124 commands of the unit tests and compared the project before and after undo. The only differences are empty ports, groups and notes lists where there were none, which the file format drops anyway. Docs: - README: the check sum. - Wiki, own commit: API (admin-only deletes, 422, file modes, lock file), Home (the "Not yet" list named three things that exist), Concepts, Keyboard, Vector art, Architecture and Development, and the 38 characters Gitea flagged as ambiguous on eight pages. - .gitignore: the lock files, and pasted-*.png in any folder, which keeps the screenshot archive out. Tests: - ./check.sh: 195 files, 2817 tests, exit 0 (+2 for the name helpers). - PHP: accounts 52 in the web container and 53 in the CI image with the race test (+2), snapshots 15 (+1), releases 20. - Full e2e run: ALL PASSED, 1586 checks (+6 in 12, 47, 49 and 50). - Smokes jumprun, tetris, actor: 24, 19 and 21 checks. The example project files were restored byte for byte afterwards. - The file stores of HEAD and of this commit give byte-identical output for the live folders and for store, list and delete in a throwaway folder. - Counter-checks, all fail as expected: a 500 for bad bytes fails 12, no admin check fails 49, removing the lock file again loses saves in 3 of 3 runs (151 to 170 of 321), Delete ignoring shapes fails 47, Escape that only closes fails 50, and dropping the shape case fails the type check (TS2366). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-29 18:12:55 +02:00
adminandClaude Opus 5.5	ceaa44e5b8	Add roles and a user management tab for admins (#180, #179) ... Until now every account could do the same, and managing accounts meant running make-user.php on the server. Accounts now carry a role, and admins get a tab in the editor to create, rename, re-role, reset and delete accounts. Both issues share the same server files, so they land in one commit. #180 Roles: - Every account is admin or user. A missing or unknown role counts as user, on the server and in the client. - auth/session and auth/login return {user, role}. - Auth::requireAdmin() answers everyone else with 403. - make-user.php takes the role as a third argument. Without it an existing account keeps its role, so a password reset from the CLI never demotes an admin. - Admins see and save other users' projects like their own. Saving keeps the original owner. #179 User management: - The account menu gets "User management" (admins only) and "Plugins" (everyone). Both open the same closable tab, accounts on top and plugins below. The fixed Plugins tab is gone. - Per account: Rename, Role, Password (no old password needed) and Delete with a confirmation. "New user..." creates one. - Each account lists its projects with an Open button. - Delete is refused while the account still owns projects. - Renaming moves the projects along and ends every session of the account. transfer takes the same lock as save. - On their own row an admin can only set the password. The last admin cannot be demoted or deleted. The server enforces both. - The account rules live in AccountRules.php and accountRules.ts as pure functions, so they are testable without a server. Findings: - At 1280 px the Delete button reached past the column edge and was not clickable. The name column is flexible now, and module 49 checks the layout. - The server lets an admin delete other users' projects, but the editor has no button for it yet. Left open in the issue. Tests: - ./check.sh: 148 files, 2214 tests, exit 0 (was 147 / 2204). - New tests/php/accounts.test.php, 51 checks, plain PHP. CI runs it as its own step in the gate job, the host has no PHP. - New e2e module 49 with 18 checks. CI creates the e2e-admin account in serve.sh. Modules 14, 38, 46 and the scaffold follow the new tab. - e2e 1-16,37,38,45,46,49: all passed, 581 checks. - Counter-checks: owner on save, admin view, default role and self delete in PHP fail 7, 5, 5 and 1 checks. Unchecked requireAdmin, a wider column and the caller as owner each fail exactly their e2e check. - Check sum 1314 -> 1333 (+1 in 38, +18 in 49), computed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-23 13:59:04 +02:00