Dragging a band of a Filter or a Parametric EQ ran at about 30 fps
in a large project. Each frame of a drag announces the changed
project, and every listener of that event ran, also those whose work
nobody sees while the drag goes on.
- FramePreview marks its own frame, read through isDragFrame().
- The Scene view behind another tab skips such a frame and draws on
coming back, as it already did while a game runs (#265).
- preloadProjectFiles skips it as well. It walks every asset and
checks every bake, which costs milliseconds in a large project.
- The command that ends a drag emits for itself, and a drag that
changes nothing ends with a plain preview, so both catch up then.
- This holds for every drag through FramePreview, the knobs of the
devices in the graph included.
Measured on stein2 with a copy of a project of 162 assets, a band of
a Parametric EQ dragged at 250 pointer moves a second for 3 s:
- Listeners per frame: 17 ms before, 7.4 ms after.
- Hidden Scene view: 814 ms before, 53 ms after.
- preloadProjectFiles: 514 ms before, 0.4 ms after.
- What is left is mostly the Hierarchy and Assets panels on screen
(about 3 and 1.3 ms a frame). They stay as they are.
Tests:
- Unit frame-preview, play-throttle: 29 passed (1 new)
- Counter-check: without the mark the new test fails
- e2e 34 (melektaus-atx): ALL PASSED, 136 checks
- Gate (melektaus-atx): CHECK EXIT 0, 288 files, 4417 tests
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scene view, texture tab and graph called state.preview() on every
pointer move. Each call rebuilds panels, the editor run and generated
images, so a drag in a busy project cost up to 34 ms per move. The
model is still written on every move. Only the preview now waits for
the next frame.
- New FramePreview in src/editor/framePreview.ts. request() goes into
the move handler, cancel() into the release. The rule lives in one
place instead of six copies.
- Scene view: object drag, polygon corners and tilemap strokes use it.
- Texture tab: frames, slice edges and collision corners use it.
- Graph: nodes, groups and comments use it through GraphDrags. That
covers the state machine, shader and particle tabs as well.
- Vector art is unchanged. Its frame already writes the model since
#129.
Findings:
- The texture tab paid twice per move (232 project events for 120
moves). Pixi sends a second pointer event 4 to 8 ms after each real
move as a hover update. It now lands in the same frame for free.
- Inspector scrubbing and gradient stop dragging still preview on
every input. Both lie outside the three canvases of the issue.
Measured with a throwaway probe, 120 moves at 8 ms, 120 extra objects:
scene 26.2 -> 18.5 ms/move, texture 34.2 -> 17.9, graph 28.8 -> 17.0.
Project events dropped from 120/232/119 to 48/48/41.
Tests:
- ./check.sh: 147 files, 2204 tests, exit 0 (before 146 / 2199).
- 5 new unit tests in tests/editor/frame-preview.test.ts, including
the real GraphDrags. Counter-checks (direct preview in the graph,
no cancel on release, one key per name) each fail the expected test.
- e2e 1-16,29,31,36,37,39-43: 708 checks passed.
- e2e 1-16,26,28: 634 checks passed.
- No new e2e check, the check sum stays at 1314.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adminandClaude Opus 5.5