5 Commits

Include renames

Author	SHA1	Message	Date
adminandClaude Opus 5.5	32a0af6e2c	Put the text and boxes of the interface on device pixels ... On a screen scaled to 125 % or 150 % the editor looked soft beside a page the browser draws itself. The layout counts in whole CSS pixels, and most of those fall between two device pixels there. The GPU averages both: text loses its edges, and a 1 px line becomes a pixel and a half of mixed colour. Now text and boxes are rounded to device pixels, and a line is one device pixel wide. - ui/pixelGrid.ts holds the rule. crispText() makes a text with Pixi's roundPixels, crisp() does the same for a Graphics of upright boxes, and hairline() is the width of one device pixel. - Every text of the interface is made with crispText() instead of new Text(). - crisp() only rounds where the scale is not a whole number. At 100 % and 200 % nothing changes. - drawControlBox, drawHeaderBar and drawSectionBand draw their lines a hairline wide and flush with the edge. The widgets that draw lines of their own do the same. - Two bands share exactly the line they draw, and a column still ends on a whole pixel. - The stage is nudged by 1/32 px where the scale is not whole. At 150 % every odd pixel is an exact half, and without the nudge one band came out a row shorter than its neighbours. - Curves, icons and everything of the game stay unrounded. Rounding their points would bend them. - The harness takes deviceScaleFactor as an option, and the hooks deviceColumn, edgeContrast and pixelGrid read the frame as the screen gets it. Not in here: the subpixel smoothing a browser gives its own text. Pixi draws a text into a transparent picture first, and there only greyscale smoothing is possible. Measured at 150 %, edge contrast before and after: top bar 31.5 to 47.8, the lists on the left 68.6 to 86.4, inspector 27.6 to 38.4. At 100 % it is 46.5, 90.1 and 37.9, and the picture there is the same as before pixel for pixel, apart from the fps display. Tests: - Gate on melektaus-atx: 206 files, 3114 tests (3104 + 10), exit 0 - Full run on melektaus-atx: 1655 of 1656 checks passed, smokes 24/19/21. The one that failed was a condition of the new step 62 itself: it scrolled an inspector that had nothing to scroll. The step now makes the window lower for that reading. - e2e 61,62 after that fix: 14 checks. The full run was not repeated, and CI is switched off for now. - Ten unit tests, nine in tests/ui/pixel-grid.test.ts - Eight e2e checks in the new step 62, which runs at 150 % - Eleven unit counter-probes fail tests - Four browser counter-probes fail their checks. They ran before the fix to step 62 and were not repeated for it. - Screenshots looked at for 125 % and 150 % Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 08:42:26 +02:00
adminandClaude Opus 5.5	bc688f3efc	Refactoring round 7: split BehaviorSystem, fewer copies (#85) ... Recurring cleanup round over the code since round 6 (056a622), 105 commits. Behaviour is unchanged. Duplicated code in src went from 29 clones with 229 lines (0.32 %) to 14 clones with 109 lines (0.15 %), measured with jscpd and the same settings as round 6. - BehaviorSystem.ts shrinks from 941 to 589 lines. Collecting the pulses (keys, timers, collisions, animations) moved to behaviorPulses.ts. The NodeContext the nodes receive moved to behaviorContext.ts. Imports from outside stay the same, TimeScaled is still exported from BehaviorSystem.ts. - PointKindButton and drawPointGrip replace the "Point:" button with its menu and the point and handle drawing that the curve and the vector art tab each had on their own. - lerpVec, cubicAt and splitCubic in src/core/util/vec.ts replace four copies of the cubic curve and two de Casteljau splits. - mapNested in Properties.ts is the one walk over lists and structs that liveObjects and objectRefs did separately. withFieldRenamed and withoutField replace three copies of renaming a struct field and two of removing one. - jsonBody and staleRevision build the JSON body and turn a 409 into StaleRevisionError for all stores. The auth store turns a 401 into its error in one place. - Smaller helpers: structAssetFrom for the two "Make struct type" commands, shownObject in the inspector, selectedItem for the size gizmo and the polygon corners, solidTiles in the tilemap collision, requireVariablesAsset and requireBehaviorVariable. - Left as is on purpose: the plain forwarding from the collision and physics systems to Solids, the pointer wiring of the canvases and the identical last lines of the two make commands. - Removed unused code: tilemapTileIds and tilemapsUsing were never called since #128 and #131. EditorState.runtimeProject became unused with GameRun in #266. The assetId getter of the make commands was read only by a test. - 60 values used only in their own file lost their export. The shader and particle node catalogues stay exported as in round 6. - Five comments that told history now describe the current state. The doc comment of BehaviorSystem sits on the class again. - README lists the struct, clip area and curve assets and mentions the game link from #266. Findings: - Deleting a tile that is painted on a tilemap leaves its cells in place, and they draw nothing. The delete dialog does not mention the tilemaps. That was probably the job of the unused tilemapsUsing. Left as is, because fixing it changes behaviour. - The solid filter for tile surfaces was untested. A bent filter stayed green. A new test in tests/core/surface.test.ts now fails against it. Tests: - ./check.sh: 195 files, 2815 tests, exit 0 (one test removed with tilemapsUsing, one added for tile surfaces). - Full e2e run: ALL PASSED, 1580 checks. - Smokes jumprun, tetris, actor: 24, 19 and 21 checks, all passed. The example project files were restored byte for byte afterwards. - Counter-checks, 12, all fail as expected: 10 in unit tests (among them mapNested, splitCubic, cubicAt, staleRevision, the stay pulse, the late timer and the time scale), 2 in the browser (Point button always enabled fails 47, selectedItem without a hit fails 29). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-29 16:16:37 +02:00
adminandClaude Opus 5.5	d2701b3ec5	Scroll the image tile into view before clicking it in e2e 12 ... The image picker scrolls once the texture store holds more images than fit into the dialog. The hook imagePickerTile still reports the tile position then, so the click in module 12 landed outside the visible list and picked nothing. Locally spare.png sat at place 27 of 32, and the full run broke off in module 12 with "Texture not found". - FilePicker exposes its scroll area as listView. - The new test hook __gm.imagePickerRect() returns that area. - Both tile clicks in module 12 wheel the tile into view first with the existing inView helper, as modules 41 and 43 do. The editor behaves the same. Only the hook is new. The texture store is shared with real projects, so the seed does not clean it up. Tests: - ./check.sh: 188 files, 2746 tests, CHECK EXIT 0 - GM_STEPS=10,12: ALL PASSED, 58 checks - Full local run: ALL PASSED, 1535 checks - Counter-check: the old module 12 against the same bundle gives 6 FAILED (selected: null, then "Texture not found") Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-28 19:27:55 +02:00
adminandClaude Opus 5	ae3aa7d3bd	Refactoring round 5 covers the code since round 4 without changing behaviour: four identical copies of dot() and three of "nearest point on a segment" stood in the collision math, in the hit area of the collider outlines and in the polygon handles, so they moved into the new module src/core/util/vec.ts; the warning line, the busy state, info() and the caret reset were written out line by line in both the sign-in screen and the password dialog and are now FormStatus; the closing row "Cancel plus a confirming button, optionally one on the left" was built by hand in FormDialog, FilePicker, OpenProjectDialog and PasswordDialog and is now dialogButtons(); the header bar was drawn by the toolbar, the TabHeader and the Breadcrumb each on its own and is now drawHeaderBar(); AddColliderCommand and AddRigidbodyCommand share a base, each subclass only builds its own asset; Editor.ts derives the panes from assetEditors instead of repeating eight entries and clamps its splitters with clamp(); jscpd over src falls from 0.19 % to 0.14 %; dead code is gone - listScenes() has been orphaned since the Scene picker fell away (#183), DEFAULT_FILTER (#152) was never used, the two test hooks projectPickerRowAt/rowPosition and particleCompiles are read by no tool, and four functions lost an export they did not need; seven comments that told history ("used to", "no longer", "since #...") describe the state of things now, and that this changed nothing was proved by a rebuild - the bundle is md5 identical, b4ad0dfe... before and after; the README said Logout sits at the far right of the toolbar, which has been the Account menu since #182, and wiki/Architecture.md was missing src/core/util/ altogether; 4 new unit tests cover vec.ts, and switching the clamp on the segment off makes exactly one of them fail while none of the 76 neighbouring tests notice, so that clamping was covered nowhere before (#85) ... Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-20 17:24:42 +02:00
adminandClaude Fable 5.1	cc6db5f350	Three stores, three importers and three pickers that differ only in their type are one of each (#85) ... Refactoring round one: HttpFontStore/HttpSoundStore/HttpTextureStore collapse into a generic HttpFileStore over a FileStore contract; fontImport/soundImport/textureImport share assetImport with an ImportKind per sort; ImagePicker/FontPicker/SoundPicker sit on FilePicker and describe only their row. The group/comment drag logic leaves GraphCanvas for annotationDrag.ts (with its own unit test), declaredRows.ts replaces the duplicated row build in particles.ts and shaders.ts, and dead code in font/sound/compile/emission/transform/actions is gone. README: asset list, check count 958, the two-job CI, the Scenes wiki page. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>	2026-09-16 17:38:54 +02:00