3 Commits

Include renames

Author	SHA1	Message	Date
adminandClaude Opus 5.5	bc688f3efc	Refactoring round 7: split BehaviorSystem, fewer copies (#85) ... Recurring cleanup round over the code since round 6 (056a622), 105 commits. Behaviour is unchanged. Duplicated code in src went from 29 clones with 229 lines (0.32 %) to 14 clones with 109 lines (0.15 %), measured with jscpd and the same settings as round 6. - BehaviorSystem.ts shrinks from 941 to 589 lines. Collecting the pulses (keys, timers, collisions, animations) moved to behaviorPulses.ts. The NodeContext the nodes receive moved to behaviorContext.ts. Imports from outside stay the same, TimeScaled is still exported from BehaviorSystem.ts. - PointKindButton and drawPointGrip replace the "Point:" button with its menu and the point and handle drawing that the curve and the vector art tab each had on their own. - lerpVec, cubicAt and splitCubic in src/core/util/vec.ts replace four copies of the cubic curve and two de Casteljau splits. - mapNested in Properties.ts is the one walk over lists and structs that liveObjects and objectRefs did separately. withFieldRenamed and withoutField replace three copies of renaming a struct field and two of removing one. - jsonBody and staleRevision build the JSON body and turn a 409 into StaleRevisionError for all stores. The auth store turns a 401 into its error in one place. - Smaller helpers: structAssetFrom for the two "Make struct type" commands, shownObject in the inspector, selectedItem for the size gizmo and the polygon corners, solidTiles in the tilemap collision, requireVariablesAsset and requireBehaviorVariable. - Left as is on purpose: the plain forwarding from the collision and physics systems to Solids, the pointer wiring of the canvases and the identical last lines of the two make commands. - Removed unused code: tilemapTileIds and tilemapsUsing were never called since #128 and #131. EditorState.runtimeProject became unused with GameRun in #266. The assetId getter of the make commands was read only by a test. - 60 values used only in their own file lost their export. The shader and particle node catalogues stay exported as in round 6. - Five comments that told history now describe the current state. The doc comment of BehaviorSystem sits on the class again. - README lists the struct, clip area and curve assets and mentions the game link from #266. Findings: - Deleting a tile that is painted on a tilemap leaves its cells in place, and they draw nothing. The delete dialog does not mention the tilemaps. That was probably the job of the unused tilemapsUsing. Left as is, because fixing it changes behaviour. - The solid filter for tile surfaces was untested. A bent filter stayed green. A new test in tests/core/surface.test.ts now fails against it. Tests: - ./check.sh: 195 files, 2815 tests, exit 0 (one test removed with tilemapsUsing, one added for tile surfaces). - Full e2e run: ALL PASSED, 1580 checks. - Smokes jumprun, tetris, actor: 24, 19 and 21 checks, all passed. The example project files were restored byte for byte afterwards. - Counter-checks, 12, all fail as expected: 10 in unit tests (among them mapNested, splitCubic, cubicAt, staleRevision, the stay pulse, the late timer and the time scale), 2 in the browser (Point button always enabled fails 47, selectedItem without a hit fails 29). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-29 16:16:37 +02:00
adminandClaude Opus 5.5	6015869297	Let the scene view hide symbols, names and shapes per asset kind ... The scene view gets crowded once a scene holds many behaviors, colliders and tilemaps. A new eye button in the topbar opens a list of all placeable asset kinds, and each row has toggles for what the scene view draws for that kind. - The popup lists all 9 placeable kinds from Behavior to Tilemap, with the columns Symbol, Name and Shape. It stays open while switching. - Sprite, Text and Tilemap draw no symbol, so their symbol toggle is greyed out. Their name toggle shows a new centred name tag, which is off by default. - Shape exists for Collider and Tilemap. A hidden collider outline is neither drawn nor clickable. A hidden tilemap shape removes the collision outlines and the paint tint, the tiles stay visible. - A hidden symbol takes no slot in the ring and draws no dashed link to its parent. A name that stays on moves to the centre of the object. - The setting lives in the project as `sceneVisibility`, not in localStorage. Older projects load with the defaults, which match the view as it was. - Switching has no undo step, like the game scale. It only changes the view. A change made during Play survives Stop. - The rules sit in `src/core/model/sceneVisibility.ts`, the popup in `src/editor/panels/SceneVisibilityPopup.ts`. Four new SVG icons. Not covered by a check: symbol off with name on for a kind with a symbol, Text and Tilemap with names, and the paint tint with shape off. Tests: - ./check.sh: 173 files, 2515 tests, CHECK EXIT 0 - e2e 46: ALL PASSED, 17 checks. 46g clicks the popup, lays a small tilemap over the crate and removes it again. - e2e 8 alone on a fresh seed: ALL PASSED, 23 checks. A red check in the partial run 2,8,46 came from the module selection. - 8 new unit tests in tests/editor/scene-visibility.test.ts. - 4 counter-probes, each fails its test: load ignores the saved value, Play skips the saved model, scene view ignores collider shape, scene view ignores tilemap shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-26 23:32:58 +02:00
adminandClaude Opus 5	60d0146bde	The topbar is icons only: the leading Project dropdown, the Scene picker and the labelled Play/Pause buttons are gone and in their place stand five icon buttons - menu, undo, redo on the left, play and pause in the middle - while Notice, the save state, fps and the Account menu keep the right side; the Play button swaps its icon for a stop square while the project runs and Pause swaps for a second play sign while it is held (Button.setIcon()), and iconSpace() drops the gap between icon and label when a button has no label, which is what kept a 24 px icon button 3 px off its own centre; the menu carries New project, Open project..., a separator and Project settings..., where the picker (src/editor/OpenProjectDialog.ts) preselects the open project and marks it "open", opens on a double click and puts Delete on the left of Cancel and Open - it closes itself before it asks whether to delete, because two modals on top of each other would have left the question standing over a list it no longer speaks about - and the settings dialog (src/editor/ProjectSettingsDialog.ts) holds the name, the "Play starts" switch (Start scene / Active scene, a preference of this browser and so no command) and the collision layers from #152, which retires CollisionLayersDialog.ts and the "Collision layers..." entry; what Apply actually writes is the pure function settingsChanges(), so renaming and the layers are each their own undo step and each drop out when nothing differs; the Scene dropdown falls away without replacement, the active scene is switched by double clicking it in the Assets panel, which is the way that was there anyway; new module 46 runs last with 9 checks (no label left in the bar, the run buttons in edit mode, the four menu entries, the picker with the open project preselected, Cancel leaving the project standing, the settings dialog on the state of the project, renaming with undo and redo through the icon buttons) and it neither opens nor deletes a project, because that would pull the project out from under every earlier module; modules 8, 18 and 35 and the harness follow the new bar, 6 unit tests cover settingsChanges and 3 the icons (#183) ... Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-09-20 16:34:14 +02:00