2 Commits

Include renames

Author	SHA1	Message	Date
adminandClaude Opus 5.5	bc688f3efc	Refactoring round 7: split BehaviorSystem, fewer copies (#85) ... Recurring cleanup round over the code since round 6 (056a622), 105 commits. Behaviour is unchanged. Duplicated code in src went from 29 clones with 229 lines (0.32 %) to 14 clones with 109 lines (0.15 %), measured with jscpd and the same settings as round 6. - BehaviorSystem.ts shrinks from 941 to 589 lines. Collecting the pulses (keys, timers, collisions, animations) moved to behaviorPulses.ts. The NodeContext the nodes receive moved to behaviorContext.ts. Imports from outside stay the same, TimeScaled is still exported from BehaviorSystem.ts. - PointKindButton and drawPointGrip replace the "Point:" button with its menu and the point and handle drawing that the curve and the vector art tab each had on their own. - lerpVec, cubicAt and splitCubic in src/core/util/vec.ts replace four copies of the cubic curve and two de Casteljau splits. - mapNested in Properties.ts is the one walk over lists and structs that liveObjects and objectRefs did separately. withFieldRenamed and withoutField replace three copies of renaming a struct field and two of removing one. - jsonBody and staleRevision build the JSON body and turn a 409 into StaleRevisionError for all stores. The auth store turns a 401 into its error in one place. - Smaller helpers: structAssetFrom for the two "Make struct type" commands, shownObject in the inspector, selectedItem for the size gizmo and the polygon corners, solidTiles in the tilemap collision, requireVariablesAsset and requireBehaviorVariable. - Left as is on purpose: the plain forwarding from the collision and physics systems to Solids, the pointer wiring of the canvases and the identical last lines of the two make commands. - Removed unused code: tilemapTileIds and tilemapsUsing were never called since #128 and #131. EditorState.runtimeProject became unused with GameRun in #266. The assetId getter of the make commands was read only by a test. - 60 values used only in their own file lost their export. The shader and particle node catalogues stay exported as in round 6. - Five comments that told history now describe the current state. The doc comment of BehaviorSystem sits on the class again. - README lists the struct, clip area and curve assets and mentions the game link from #266. Findings: - Deleting a tile that is painted on a tilemap leaves its cells in place, and they draw nothing. The delete dialog does not mention the tilemaps. That was probably the job of the unused tilemapsUsing. Left as is, because fixing it changes behaviour. - The solid filter for tile surfaces was untested. A bent filter stayed green. A new test in tests/core/surface.test.ts now fails against it. Tests: - ./check.sh: 195 files, 2815 tests, exit 0 (one test removed with tilemapsUsing, one added for tile surfaces). - Full e2e run: ALL PASSED, 1580 checks. - Smokes jumprun, tetris, actor: 24, 19 and 21 checks, all passed. The example project files were restored byte for byte afterwards. - Counter-checks, 12, all fail as expected: 10 in unit tests (among them mapNested, splitCubic, cubicAt, staleRevision, the stay pulse, the late timer and the time scale), 2 in the browser (Point button always enabled fails 47, selectedItem without a hit fails 29). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-29 16:16:37 +02:00
adminandClaude Opus 5.5	ceaa44e5b8	Add roles and a user management tab for admins (#180, #179) ... Until now every account could do the same, and managing accounts meant running make-user.php on the server. Accounts now carry a role, and admins get a tab in the editor to create, rename, re-role, reset and delete accounts. Both issues share the same server files, so they land in one commit. #180 Roles: - Every account is admin or user. A missing or unknown role counts as user, on the server and in the client. - auth/session and auth/login return {user, role}. - Auth::requireAdmin() answers everyone else with 403. - make-user.php takes the role as a third argument. Without it an existing account keeps its role, so a password reset from the CLI never demotes an admin. - Admins see and save other users' projects like their own. Saving keeps the original owner. #179 User management: - The account menu gets "User management" (admins only) and "Plugins" (everyone). Both open the same closable tab, accounts on top and plugins below. The fixed Plugins tab is gone. - Per account: Rename, Role, Password (no old password needed) and Delete with a confirmation. "New user..." creates one. - Each account lists its projects with an Open button. - Delete is refused while the account still owns projects. - Renaming moves the projects along and ends every session of the account. transfer takes the same lock as save. - On their own row an admin can only set the password. The last admin cannot be demoted or deleted. The server enforces both. - The account rules live in AccountRules.php and accountRules.ts as pure functions, so they are testable without a server. Findings: - At 1280 px the Delete button reached past the column edge and was not clickable. The name column is flexible now, and module 49 checks the layout. - The server lets an admin delete other users' projects, but the editor has no button for it yet. Left open in the issue. Tests: - ./check.sh: 148 files, 2214 tests, exit 0 (was 147 / 2204). - New tests/php/accounts.test.php, 51 checks, plain PHP. CI runs it as its own step in the gate job, the host has no PHP. - New e2e module 49 with 18 checks. CI creates the e2e-admin account in serve.sh. Modules 14, 38, 46 and the scaffold follow the new tab. - e2e 1-16,37,38,45,46,49: all passed, 581 checks. - Counter-checks: owner on save, admin view, default role and self delete in PHP fail 7, 5, 5 and 1 checks. Unchecked requireAdmin, a wider column and the caller as owner each fail exactly their e2e check. - Check sum 1314 -> 1333 (+1 in 38, +18 in 49), computed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-23 13:59:04 +02:00