"Add collider" on a sprite always made a box of the sprite's size,
even when the sprite's picture is a frame that has a collision outline.
The outline then had to be picked by hand as "Frame collision".
- newColliderProps in colliderCommands.ts is the rule as a pure
function. A sprite whose picture is a frame with an outline gets a
collider with shape "frame" and that frame. Anything else keeps the
box of the sprite's size.
- The frame is the one the sprite shows when the collider is added,
also when only this placement overrides it.
- Decided here, the issue says nothing about size: a frame collider is
as big as its frame, so a sprite drawn bigger or smaller with the
same proportions gets the collider's scale set to match.
- Decided here as well: a sprite stretched out of the frame's
proportions keeps the box, because an outline cannot be stretched
in one direction.
Tests:
- Gate: 198 files, 2914 tests (2911 + 3), exit 0
- e2e 8,42: 46 checks passed (42: +1 for 42e-ii)
- Three new unit tests in tests/core/collider-parts.test.ts: the
frame with undo, the scale with an overridden frame, and the cases
that keep the box
- 42e-ii goes through the context menu: "Frame collision" with scale
2 on the sprite wearing the wedge frame, a box on a sprite without
a picture
- Five unit counter-probes fail, 1 to 2 tests each. They ran on
stein2, not in the container.
- The browser counter-probe fails 42e-ii with shape "box"
- The e2e sum of 1617 is calculated (1616 + 1). Neither the full
suite nor the smokes ran for this state.
- Vector art has no test of its own, it takes the same branch as a
whole texture.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"Add collider" and "Add rigidbody" could only create a fresh asset.
Reusing one meant creating a copy by hand, and a new box collider
never matched the sprite it was added to.
- "Add collider…" and "Add rigidbody…" open a second menu at the same
spot: a search field, "Create new …", a separator, then every asset
of that kind sorted by name. Enter takes the first match.
- An existing asset is placed as a shared child, not copied. An asset
the object already carries is greyed out.
- The rule for when the entries are available lives in one place in
the collider commands. An object without a resolvable asset is
greyed out again, as with the old canAddCollider.
- "Fit to sprite" in the menu of a placed collider sizes it to its
sprite and centres it (position 0,0, z kept) as one undo step.
- Fit writes overrides of that placement, not the asset, because a
collider can now sit on several sprites. A value equal to the asset
value clears the override instead.
- Fit removes the collider's own scale, swaps width and height near
90 degrees and gives a circle the radius that fits (min/2). It is
greyed out for polygon and frame outlines and off a sprite.
- Menu has no submenus, so a second menu opens instead, similar to
"Add Component" in Unity. That costs one click more than before.
Tests:
- ./check.sh: 152 files, 2234 tests, CHECK EXIT 0 (before 151/2228).
- 6 new unit tests in tests/core/collider-parts.test.ts.
- 3 new e2e checks in 08a: submenu with search and greying, an
existing collider via search and Enter, Fit on oc2.
- 09, 40 and 41 follow the new labels.
- e2e 1-16,39-41 on the final build: ALL PASSED, 596 checks.
- Counter-checks: no greying, existing asset ignored and fit without
centring each fail at their own check. Breaking the override rule
fails 2 unit tests.
- CI confirmed 1345 checks at 2cf7202 (task 265). New total 1348,
calculated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adminandClaude Opus 5.5