Commit Graph
2 Commits
Author SHA1 Message Date
adminandClaude Opus 5.5 6c62aa45d5 Pick Crate 57 through the menu search in e2e 57 (#258)
CI has been red since f84defb. In the full run the scene holds more
than 40 filler objects from module 11. The object menu is height
limited and scrolls, and overlayTexts() only returns the visible rows.
Aim 57 and Crate 57 sit at the end of the scene and were never visible.

- Check None right after opening the menu, it is always the top row.
- Type 57 into the search field before looking for Aim 57 and
  Crate 57 and before clicking Crate 57, like module 7 does with the
  parent picker.
- No product code changes.

Tests:
- Reproduced with modules 1-11 and 57: the old test fails with the
  same cut-off list and "nothing to click: Crate 57" as CI.
- New test: ALL PASSED - 405 checks, all 5 checks of 57 green.
- The full run could not be verified locally. Module 12 fails here
  because the local server holds leftover uploaded images. It is
  green in CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-28 17:57:37 +02:00
adminandClaude Opus 5.5 f84defb9b6 Pick an object of the same scene for an Object variable (#258)
game-maker / gate (push) Successful in 3m32s
game-maker / suite (push) Failing after 10m2s
An Object variable could only be set by a graph while the game runs.
A placed object always showed "(null)", although the other objects of
its scene are there to choose from and the runtime can already find
any object by its id. Now the placed object stores a reference to one
of them, and the running game turns it into the real object.

- Stored as {"$object": "<id>"}. The empty placeholder stays as it
  was, so old projects load unchanged and empty still means "(null)".
- The row of an Object variable on a placed object is a dropdown with
  None and every object of the scene, indented like the Hierarchy.
  The same goes for Object fields in structs and Object items in
  lists, also in the Variables and List tabs.
- The behavior asset keeps "(null)". An asset has no scene, so "Apply
  to asset" is gone from Object rows.
- The runtime resolves the reference when the Variables or Properties
  node reads it. A destroyed target reads as null, a missing one shows
  "(missing)" in the row.
- Inside a container only objects of the same container are offered.
  The reference keeps the template id, so every placement finds its
  own copy.
- Deleting the target clears the reference in the same undo step.
  Paste points references inside the pasted group at the copies and
  leaves outside references alone. Create container and Unpack carry
  references along with the new ids.
- A value a graph writes while running stays in the run. The scene
  keeps the picked object, also in "Run in editor".

Found on the way:

- Setting an override coerced every object slot to empty, in plain
  values, struct fields and list items. The shared objectPlace() now
  keeps the reference.

Not done:

- No eyedropper to pick in the scene, the dropdown is enough for now.
- Deleting a template object in the container editor does not clean up
  references in other scenes. They read as null there.

Tests:

- ./check.sh: 187 files, 2724 tests, CHECK EXIT 0
- e2e 1-9, 51, 57: ALL PASSED, 389 checks
- e2e 1, 57 on the final bundle: ALL PASSED, 17 checks
- 13 unit tests in object-references.test.ts, 5 checks in e2e 57
- Counter-checks: 8 unit breaks fail their tests, the browser break
  without a pick list fails 57b-57d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-28 14:35:17 +02:00