3 Commits

Include renames

Author	SHA1	Message	Date
adminandClaude Opus 5.5	925a39a276	Let guests try a demo project without an account (#428) ... The editor was only open to somebody with an account. A guest now picks a demo project on the sign-in screen and gets the whole editor on a copy held in the tab. The server writes nothing for a guest, so there is no guest session, no guest folder and no quota to keep. - Demo copies are frozen copies like a release, in data/demos/. An administrator makes, updates and removes one with "Demo copy..." in the project's main menu. GET demos and GET demos/{token} need no session. An empty project is just a demo that is empty. - Demo material: an administrator offers an uploaded file with "Offer as demo" in the pickers (PATCH {demo}, data/demo-files.json). Every list carries it with demo: true, for accounts and guests alike. Signed out, a list holds the demo material alone, without the owner. - An offered file is only an administrator's to delete. A file a demo copy names counts as used, like one a release names. - The guest's project lives in MemoryProjectStore. Every store that would write refuses in the tab before a request is made, and the autosave is not attached at all. - The main menu drops projects, snapshots and release for a guest. The pickers drop Upload and Delete, a dropped or pasted file is refused, and a recording is saved as a download. - The toolbar says the work is not saved. The Account menu holds "Sign in..." instead of Logout and the password. - A guest's demo never goes into the address: a reload brings the sign-in screen back, not the copy. Found by e2e 70. - GET plugins needs no session any more, since a demo may switch one on. It only reads the server's own modules. Tests: - e2e 70 (atx): ALL PASSED, 13 checks. Counter-test with the guest autosave sent to the server: 70f and 70g red on the PUT. - tests/core/guest.test.ts: 9 tests. PHP: demos 20, files 46, rights 80 checks (the matrix asks every new route). - Gate (atx): CHECK EXIT 0, 314 files, 4852 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-16 06:58:30 +02:00
adminandClaude Opus 5.5	14972d057f	Refactoring round 8: hide data files, safe saves, Esc as Cancel (#85) ... Recurring cleanup round over the code since round 7 (bc688f3). The issue now also asks to fix bugs and small inconsistencies found on the way, so unlike the rounds before, this one changes behaviour in a few places. Duplicated code in api went from 23 clones with 228 lines to none (jscpd, at least 50 tokens). In src it stays at 22 clones with 271 lines, the same before and after. Bugs: - nginx served project and snapshot files as they were, so anyone who knew a project id could read it without signing in. Every file the API writes now goes through AtomicFile (temp file, mode, rename). Projects, snapshots, releases, accounts and sessions are 0640, and nginx answers 403 for them. - Any signed-in account could delete a shared image, font or sound, which projects of other accounts may wear. Deleting one is now for administrators only. The editor never deleted a file, so the client's delete is gone. - Two saves of one project could run at once. The lock file was removed after each save, so a waiting save and the next one locked different files. The lock file now stays, and deleting a project takes the lock as well. - Bytes that are no picture got a 500 instead of a 422, because the error handler also threw for warnings silenced with @. - A session file was rewritten in place. A request reading it at that moment found it empty and was signed out. It is replaced atomically. - Delete did nothing for a shape picked in the vector art list. Delete now goes through removeSelection, one case per kind of selection, and a kind without a case fails the type check. Inconsistencies: - Escape on a question does what its Cancel does. Cancel on "Delete project?" and "Restore snapshot?" leads back to the picker or the list like the other questions did, and so does deleting a project. - Editor texts use American spelling throughout, like the port names: 48 British spellings in 45 lines (colour, centre, initialised). - objectName and groupName replace eleven copies of "own name, else the asset's" and three of "Group". One copy fell back to the object id instead of "?". Duplicates, dead code, comments: - routeFiles serves images, fonts and sounds instead of three copies. HashedFileStore holds what the three stores shared: keeping a file under its hash with its name, listing and deleting. The stores keep only which bytes they take and what a record says. - AtomicFile replaces nine copies of temp file plus rename. - removeShapes is the one way the canvas, the inspector button and Delete take shapes out. - GraphInterpreter.fire was called by tests only. The 54 calls use a helper in tests/helpers.ts now. - FileStore.delete, HttpFileStore.delete and the PluginApi type were unused. A doc comment in actions.ts sat above the wrong function. Checked and left as is: - solidCells is used by tests only. It is the per-cell view before the merge into rectangles, the one place the largest-scale rule shows. - An undo checker ran all 124 commands of the unit tests and compared the project before and after undo. The only differences are empty ports, groups and notes lists where there were none, which the file format drops anyway. Docs: - README: the check sum. - Wiki, own commit: API (admin-only deletes, 422, file modes, lock file), Home (the "Not yet" list named three things that exist), Concepts, Keyboard, Vector art, Architecture and Development, and the 38 characters Gitea flagged as ambiguous on eight pages. - .gitignore: the lock files, and pasted-*.png in any folder, which keeps the screenshot archive out. Tests: - ./check.sh: 195 files, 2817 tests, exit 0 (+2 for the name helpers). - PHP: accounts 52 in the web container and 53 in the CI image with the race test (+2), snapshots 15 (+1), releases 20. - Full e2e run: ALL PASSED, 1586 checks (+6 in 12, 47, 49 and 50). - Smokes jumprun, tetris, actor: 24, 19 and 21 checks. The example project files were restored byte for byte afterwards. - The file stores of HEAD and of this commit give byte-identical output for the live folders and for store, list and delete in a throwaway folder. - Counter-checks, all fail as expected: a 500 for bad bytes fails 12, no admin check fails 49, removing the lock file again loses saves in 3 of 3 runs (151 to 170 of 321), Delete ignoring shapes fails 47, Escape that only closes fails 50, and dropping the shape case fails the type check (TS2366). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-29 18:12:55 +02:00
adminandClaude Opus 5.5	4194f3e150	Share a link that plays the game without the editor (#266) ... A project could only be played inside the editor, behind the login. To show a game to someone else there was no way short of an account. A release freezes the saved project under a random token and serves it on a page that holds nothing but the game view. - Menu -> Release... opens a dialog with the state of the release, the link with Copy link and Open, Publish or Update release, and Take down behind a confirmation. - Publish saves first and refuses while anything is unsaved, like snapshots. Updating keeps the link. Take down kills it, and a new Publish hands out a new token. - The link is play.html?game=<32 hex>. The page needs no session, paints Theme.colors.background, zooms with Auto and waits for "Click to play" so that sound and keyboard focus are allowed. - The game always starts in the start scene. Persistent variables are stored per link in the browser. Plugins are not loaded, and the dialog warns about them and about a project without a scene. - GET ?r=releases/{token} is the only route besides auth/* that works without a login. The public answer carries the token as project.id, so the project id stays hidden. Release files are written with 0640 and nginx does not serve them directly (measured 403). - Starting, the frame and Load scene moved into runtime/GameRun.ts. Play in the editor and the play page run through the same code. - WorldViewport moved to src/viewport/ and no longer needs the EditorState. Pointer forwarding (gamePointer.ts) and setting up textures, fonts and sounds (projectFiles.ts) exist only once. - Vite builds two pages. The play page loads 4 kB of its own code plus the shared chunk (Pixi, runtime, drawing, 653 kB) and Rapier, without the editor. Found on the way, not fixed here: data/projects/<id>.json answers 200 without a login because the files are 0644. Tests: - ./check.sh: 194 files, 2808 tests, exit 0. - tests/php/releases.test.php: 20 checks, also added to CI. - New e2e module 60 with 10 checks, played in a browser without a session. Module 46 counts the menu entries and was updated. - Full e2e run: 1572 checks passed. - Counter-checks: 3 unit, 2 PHP and 3 browser mutations all fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-09-29 13:30:38 +02:00