adminandClaude Opus 5.5
6b49a0bea7
Uploaded images, fonts and sounds belonged to nobody. Every account saw every file in the pickers, and only an administrator could delete one, through the API alone. Now every account uploads into a folder of its own, sees its own files and nobody's, and can delete a file of its own that no project uses. - Files are stored as data/<kind>/<folder>/<sha256>.<ext>, and the folder is part of asset.file. A name without a folder belongs to nobody. - The folder is a random 12-character name kept in users.json and given with the first upload. Renaming an account moves no file, and a released game's URLs carry no account name. - The list shows the caller's own files and nobody's. An administrator sees all, each with owner and deletable. - DELETE takes the name with its folder. It answers 403 unless the file is the caller's or the caller is an administrator, and 409 while a project, snapshot or release of any account names it (FileUsage). The 409 names the caller's own projects only. - The pickers have a Delete button. The first press asks, the second deletes, and a refusal shows the server's reason. - A deleted account's folder stays and only administrators see it. - tools/migrate-file-owners.php moved every used file into the folder of the account using it (a copy each for two accounts) and rewrote projects, snapshots and releases. A project's revision goes up, so an open editor gets a conflict instead of saving old names back. - Font families are named after the hash alone, so a folder never ends up in a CSS family name. Run on stein2 on 2026-10-07, backup in /root/config-backup-20261007/data-before-344: 25 files used, 27 copies, 8 projects, 53 snapshots and 1 release rewritten, 30 unused files stay nobody's. Afterwards all 600 references resolve to a file in their owner's folder. Found while building: the Delete button cut its new label to "Del…" because a button does not measure itself again on a new text. The picker now lays its button row out again. Tests: - PHP files.test.php (new): 46 checks, counter-check 3 red - Unit core + editor: 220 files, 3403 tests - e2e 34 (melektaus-atx): ALL PASSED - 67 checks (2 new) - Gate (melektaus-atx): CHECK EXIT 0, 256 files, 3977 tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
36 lines
1.5 KiB
TypeScript
36 lines
1.5 KiB
TypeScript
import { findAsset, type Project } from './Project';
|
||
import { textOf } from './Properties';
|
||
import { storedFileBase, storedFilePattern } from './storedFile';
|
||
|
||
const FILE_PATTERN = storedFilePattern('ttf|otf|woff|woff2');
|
||
|
||
export function isFontFile(name: string): boolean {
|
||
return FILE_PATTERN.test(name);
|
||
}
|
||
|
||
/**
|
||
* The CSS family a file is registered under. Derived from the content-addressed name, so the same
|
||
* bytes are always one family and two uploads of one typeface cannot fight over a name – the name
|
||
* inside the font is never used for this, only for the asset's label. The folder is left out: the
|
||
* same bytes in two accounts' folders are the same face.
|
||
*/
|
||
export function fontFamilyOf(file: string): string {
|
||
return `gm-font-${storedFileBase(file).slice(0, 16)}`;
|
||
}
|
||
|
||
/**
|
||
* Whether the face a `font` property points at is drawn smoothed, the font asset's Filter row the
|
||
* way it is a texture's. The editor's own typeface, and a dangling id, are smooth.
|
||
*/
|
||
export function fontSmoothOf(project: Project, id: string): boolean {
|
||
const asset = id === '' ? undefined : findAsset(project, id);
|
||
return asset?.type !== 'font' || textOf(asset.props.filter ?? 'linear') !== 'nearest';
|
||
}
|
||
|
||
/** The file a `font` property points at, empty when the id is unset or no longer resolves. */
|
||
export function fontFileOf(project: Project, id: string): string {
|
||
if (id === '') return '';
|
||
const asset = findAsset(project, id);
|
||
return asset?.type === 'font' ? asset.file : '';
|
||
}
|