root
1b16a55ffc
`decimals` only reached `formatNumber`, so it changed the label and nothing else: typing 640.5 into a field with `decimals: 0` stored 640.5 and displayed 641. The two existing users got away with it because rounding happened outside the widget (`normalizeFrameRect`, the slice dialog), which their comments had to point out. `NumberField.clampValue` now rounds before it clamps, and every path that sets a value goes through it (typing, scrubbing, arrow keys, the constructor), so the stored number matches the shown one and `min`/`max` stay exact. The rounding is `roundTo` in math.ts, which `snapToStep` already did inline. With that safe, camera `View width`/`View height` and text `Font size` become integers – they were showing 640.000 and 32.000. Everything else that looked integral is not: positions, sprite and collider sizes and zoom are all scrubbed, and `z` is a summed coordinate (walk.ts), not a layer. Verified remotely against the RTX 4070 host: 270 checks, all passed (step 10 gained a check that the field text has no decimal point and survives a reopen). `npm run check` green, 407 tests.
93 lines
4.1 KiB
JavaScript
93 lines
4.1 KiB
JavaScript
/** Text assets rendered in the scene, and the enabled switch in the editor and in the running game. */
|
|
export async function textAndEnabled(t) {
|
|
const {
|
|
check,
|
|
sleep,
|
|
evaluate,
|
|
json,
|
|
shot,
|
|
click,
|
|
clickText,
|
|
locate,
|
|
mutate,
|
|
object,
|
|
play,
|
|
press,
|
|
stop,
|
|
typeText,
|
|
} = t;
|
|
const has = (text) => evaluate(`Boolean(__gm.locate(${JSON.stringify(text)}))`);
|
|
|
|
// 17. Text assets: created through the + menu, placed, and rendered as real text in the scene.
|
|
await clickText('+');
|
|
await clickText('Text');
|
|
await sleep(100);
|
|
const textAssetId = await evaluate(`(__gm.state.project.assets.find(a => a.type === 'text') || {}).id`);
|
|
check('+ menu creates a text asset', Boolean(textAssetId));
|
|
await mutate(`
|
|
const id = ${JSON.stringify(textAssetId)};
|
|
__gm.state.project.assets.find(a => a.id === id).props.text = 'Hello world';
|
|
// On the camera so the game view really renders it (outside the frame it would be culled).
|
|
const cam = __gm.state.activeScene.objects.find(o => o.id === 'o3').position;
|
|
__gm.state.activeScene.objects.push({ id: 'otext', assetId: id, name: '', position: { x: cam.x, y: cam.y, z: 5 }, editorOffset: { x: 0, y: 0 }, overrides: {}, parentId: '' });
|
|
__gm.state.select({ kind: 'object', holderId: 'scene1', objectIds: ['otext'], objectId: 'otext' })`);
|
|
await sleep(100);
|
|
check('a placed text object draws its content in the scene', await has('Hello world'));
|
|
await shot('29-text-object');
|
|
|
|
// 17a. The enabled switch: every object has it, switching it off is a normal override, and a
|
|
// switched-off object disappears from the scene view too (it stays in the hierarchy).
|
|
const enabledRow = await evaluate(`__gm.locate('Enabled')`);
|
|
check('the inspector shows the Enabled switch for a scene object', Boolean(enabledRow));
|
|
const visibleBefore = (await json('__gm.viewportInfo()')).visibleItems;
|
|
// The checkbox sits right of the 64 px label column; locate() gives the label's text centre.
|
|
await click(enabledRow.x + 55, enabledRow.y);
|
|
await sleep(100);
|
|
const textObject = await object('otext');
|
|
check(
|
|
'clicking it writes an override instead of changing the asset',
|
|
textObject.overrides.enabled === false,
|
|
JSON.stringify(textObject.overrides),
|
|
);
|
|
check(
|
|
'a switched-off object is not drawn in the scene view',
|
|
!(await json('__gm.drawOrder()')).includes('otext'),
|
|
);
|
|
const visibleAfter = (await json('__gm.viewportInfo()')).visibleItems;
|
|
check(
|
|
'the scene view renders one item less',
|
|
visibleAfter === visibleBefore - 1,
|
|
`${visibleBefore} → ${visibleAfter}`,
|
|
);
|
|
check('it stays selectable in the hierarchy, so its switch stays reachable', await has('Enabled'));
|
|
await shot('30-disabled');
|
|
|
|
// 17b. In the running game a switched-off object does not exist: it is not rendered, and
|
|
// switching it back on brings it back.
|
|
await play();
|
|
await sleep(200);
|
|
const offItems = (await json('__gm.gameInfo()')).visibleItems;
|
|
await mutate(`__gm.state.activeScene.objects.find(o => o.id === 'otext').overrides.enabled = true`);
|
|
await sleep(200);
|
|
const onItems = (await json('__gm.gameInfo()')).visibleItems;
|
|
check(
|
|
'the game renders one item more once the object is switched on',
|
|
onItems === offItems + 1,
|
|
`${offItems} → ${onItems}`,
|
|
);
|
|
await stop();
|
|
check('stop leaves the play-mode switch behind', (await object('otext')).overrides.enabled === false);
|
|
|
|
// 17c. A field that shows no decimals must not store any either. Font size is such a field, so
|
|
// typing a fraction has to round: showing "33" while the project holds 32.6 would be a lie.
|
|
const fontLabel = await locate('Font size');
|
|
check('Font size reads as a whole number', Boolean(await has('32')) && !(await has('32.000')));
|
|
await click(fontLabel.x + 160, fontLabel.y);
|
|
await typeText('32.6');
|
|
await press('Enter');
|
|
await sleep(200);
|
|
const fontSize = (await object('otext')).overrides.fontSize;
|
|
check('typing a fraction into it rounds the stored value', fontSize === 33, String(fontSize));
|
|
check('and the field shows exactly what was stored', Boolean(await has('33')));
|
|
}
|