adminandClaude Opus 5.5
6b49a0bea7
Uploaded images, fonts and sounds belonged to nobody. Every account saw every file in the pickers, and only an administrator could delete one, through the API alone. Now every account uploads into a folder of its own, sees its own files and nobody's, and can delete a file of its own that no project uses. - Files are stored as data/<kind>/<folder>/<sha256>.<ext>, and the folder is part of asset.file. A name without a folder belongs to nobody. - The folder is a random 12-character name kept in users.json and given with the first upload. Renaming an account moves no file, and a released game's URLs carry no account name. - The list shows the caller's own files and nobody's. An administrator sees all, each with owner and deletable. - DELETE takes the name with its folder. It answers 403 unless the file is the caller's or the caller is an administrator, and 409 while a project, snapshot or release of any account names it (FileUsage). The 409 names the caller's own projects only. - The pickers have a Delete button. The first press asks, the second deletes, and a refusal shows the server's reason. - A deleted account's folder stays and only administrators see it. - tools/migrate-file-owners.php moved every used file into the folder of the account using it (a copy each for two accounts) and rewrote projects, snapshots and releases. A project's revision goes up, so an open editor gets a conflict instead of saving old names back. - Font families are named after the hash alone, so a folder never ends up in a CSS family name. Run on stein2 on 2026-10-07, backup in /root/config-backup-20261007/data-before-344: 25 files used, 27 copies, 8 projects, 53 snapshots and 1 release rewritten, 30 unused files stay nobody's. Afterwards all 600 references resolve to a file in their owner's folder. Found while building: the Delete button cut its new label to "Del…" because a button does not measure itself again on a new text. The picker now lays its button row out again. Tests: - PHP files.test.php (new): 46 checks, counter-check 3 red - Unit core + editor: 220 files, 3403 tests - e2e 34 (melektaus-atx): ALL PASSED - 67 checks (2 new) - Gate (melektaus-atx): CHECK EXIT 0, 256 files, 3977 tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
75 lines
2.6 KiB
TypeScript
75 lines
2.6 KiB
TypeScript
import { Button, type ButtonOptions, HStack, Label, Popup, Spacer, Theme, type Widget } from '../ui';
|
||
|
||
/** Matches the inspector's label column. */
|
||
const LABEL_WIDTH = 76;
|
||
|
||
/**
|
||
* A small modal form – the texture's Slice dialog, the timeline's row and frames dialogs: a bold
|
||
* title, rows led by a label in the inspector's label column, Cancel and a confirming button last.
|
||
*/
|
||
export abstract class FormDialog extends Popup {
|
||
protected constructor(minWidth: number, title: string) {
|
||
super({ modal: true, padding: Theme.padding * 2, gap: Theme.gap });
|
||
this.minWidth = minWidth;
|
||
this.content.add(new Label(title, { style: 'bodyBold' }));
|
||
}
|
||
|
||
protected fieldLabel(text: string): Label {
|
||
const label = new Label(text, { style: 'muted' });
|
||
label.minWidth = LABEL_WIDTH;
|
||
return label;
|
||
}
|
||
|
||
/** A row of `widgets`, left-aligned at the height of an inspector row. */
|
||
protected formRow(...widgets: Widget[]): HStack {
|
||
const row = new HStack({ gap: Theme.gap, align: 'center' });
|
||
row.minHeight = Theme.rowHeight;
|
||
for (const widget of widgets) row.add(widget);
|
||
row.add(new Spacer(), 1);
|
||
return row;
|
||
}
|
||
|
||
/** Cancel and the confirming button, right-aligned; the dialog closes before `onConfirm` runs. */
|
||
protected addButtons(text: string, variant: ButtonOptions['variant'], onConfirm: () => void): Button {
|
||
const confirm = new Button(text, { variant });
|
||
confirm.onClick = this.closeThen(onConfirm);
|
||
this.content.add(dialogButtons(this.closeThen(), confirm));
|
||
return confirm;
|
||
}
|
||
}
|
||
|
||
/** The row a dialog ends on: Cancel and `confirm` on the right, `leading` – if any – on the left. */
|
||
export function dialogButtons(
|
||
onCancel: () => void,
|
||
confirm: Button,
|
||
leading?: Button | readonly Button[],
|
||
): HStack {
|
||
const buttons = new HStack({ gap: Theme.gap, align: 'center' });
|
||
for (const button of leading === undefined ? [] : Array.isArray(leading) ? leading : [leading]) {
|
||
buttons.add(button);
|
||
}
|
||
buttons.add(new Spacer(), 1);
|
||
const cancel = new Button('Cancel');
|
||
cancel.onClick = onCancel;
|
||
buttons.add(cancel);
|
||
buttons.add(confirm);
|
||
return buttons;
|
||
}
|
||
|
||
/** One open dialog of a kind at a time: opening the next closes the last. `current` is for the check scripts. */
|
||
export function dialogSlot<T extends Popup>(): { current(): T | null; open(dialog: T): T } {
|
||
let current: T | null = null;
|
||
return {
|
||
current: () => current,
|
||
open(dialog) {
|
||
current?.close();
|
||
current = dialog;
|
||
dialog.onClose = () => {
|
||
if (current === dialog) current = null;
|
||
};
|
||
dialog.openCentered();
|
||
return dialog;
|
||
},
|
||
};
|
||
}
|