Files
feuerwerk/src/core/graph/nested.ts
T
adminandClaude Opus 5.5 7c70245c79
game-maker / gate (push) Successful in 3m3s
game-maker / suite (push) Failing after 8m39s
Let a nested behavior keep its variables between calls (#229)
A Run behavior call started with fresh variables every time, so a
nested behavior could not count, remember or keep a local state
machine across calls. A new "Keep state" switch on the node lets the
callee resume where its last call left off. It is off by default, so
existing projects run unchanged.

- RunBehavior gets the boolean parameter keepState and its node
  description explains it.
- GraphInterpreter keeps the state in keptCalls, keyed by the call
  path, the chain of Run behavior nodes. Two nodes calling the same
  behavior each keep their own state.
- One interpreter exists per behavior instance, so every object gets
  its own state without further code.
- Local state machines of the callee are kept like its variables.
- resumedVariables() matches kept values against today's
  declarations. A new variable starts at its default, a removed one
  drops out, and one whose kind changed starts over.
- The kept state lives as long as the object in the run. It is not
  written to save games.

Limit: a callee input named keepState collides with the switch. The
same already holds for the name behavior, so it is not caught.

Tests:
- ./check.sh: 163 files, 2388 tests, CHECK EXIT 0 (before 2377)
- 10 new unit tests in tests/core/keep-state.test.ts and 1 new
  node catalog case.
- e2e 19: ALL PASSED, 35 checks, with the new check 19c-ii for the
  checkbox, its click and undo.
- Counter probes: ignoring keepState fails 5 tests, state per
  behavior instead of per node fails 1, dropping the outer path
  fails 1, skipping the kind check fails 1, and without the node
  parameter the e2e check fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-09-25 14:41:17 +02:00

287 lines
11 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
import { type PropertyBag, textOf } from '../model/Properties';
import { isTaggedKind } from '../properties/kinds';
import { flatDef, isValidFieldName, type PropertyDef } from '../properties/PropertySchema';
import {
type DeclaredPort,
declaredPortType,
edgesInto,
findNode,
type Graph,
type GraphEdge,
type GraphNode,
type PortType,
} from './Graph';
import type { GraphLookup } from './lookup';
import { nodeDef, type NodeDef, type PortDef } from './NodeRegistry';
import { agreedType, type SharedPortGroup } from './portTypes';
export const BEHAVIOR_START = 'BehaviorStart';
export const BEHAVIOR_END = 'BehaviorEnd';
export const RUN_BEHAVIOR = 'RunBehavior';
export const VARIABLES = 'Variables';
export const PROPERTIES = 'Properties';
export const BEHAVIOR_PARAM = 'behavior';
export const KEEP_STATE_PARAM = 'keepState';
export const VARIABLES_PARAM = 'variablesAsset';
/** Whose declarations a `Variables` node reads; empty is the behavior the node sits in. */
export const VARIABLES_SETTING: PropertyDef = {
key: VARIABLES_PARAM,
label: 'Variables',
kind: 'asset',
default: '',
assetTypes: ['variables'],
};
export function variablesSourceOf(params: PropertyBag): string {
return textOf(params[VARIABLES_PARAM] ?? '');
}
/**
* Nodes whose declared ports are not names of their own but variables of the behavior around them.
* Renaming a variable therefore has to reach them, and the inspector picks their ports from a list
* instead of letting them be typed.
*/
export function declaresVariablePorts(type: string): boolean {
return type === VARIABLES;
}
/** Nodes whose declared ports are properties of the object they are handed. */
export function declaresPropertyPorts(type: string): boolean {
return type === PROPERTIES;
}
/** Identifier-like, and not `exec`: that key belongs to the fixed flow port of every terminal node. */
export function isValidPortName(name: string): boolean {
return isValidFieldName(name) && name !== 'exec';
}
/**
* Keys a declared port cannot take: the node's fixed ports on the side it declares (`object`), and
* its settings, which share the params bag with the typed-in values of its inputs.
*/
export function fixedPortKeys(def: NodeDef): string[] {
const side = def.declaresPorts;
const fixed =
side === 'inputs' ? def.inputs : side === 'outputs' ? def.outputs : [...def.inputs, ...def.outputs];
return [...fixed.map((p) => p.key), ...def.params.map((p) => p.key)];
}
function declaredOn(
def: NodeDef,
ports: readonly DeclaredPort[],
side: 'inputs' | 'outputs',
): DeclaredPort[] {
if (def.declaresPorts === 'both') return side === 'outputs' ? [...ports] : ports.filter((p) => p.write);
return def.declaresPorts === side ? [...ports] : [];
}
/** What a collapsed Variables or Properties node does, since its ports are out of sight. */
export function collapsedTitle(ports: readonly DeclaredPort[], noun: string): string {
const set = ports.filter((p) => p.write);
const get = ports.filter((p) => !p.write);
if (set.length > 1) return `Set ${set.length} ${noun}`;
if (get.length > 1) return `Get ${get.length} ${noun}`;
if (set[0]) return `Set ${set[0].key}`;
if (get[0]) return `Get ${get[0].key}`;
return `No ${noun}`;
}
/** The single start (or end) node of a graph; a second one is ignored. */
export function terminalNode(graph: Graph, type: string): GraphNode | undefined {
return graph.nodes.find((n) => n.type === type);
}
export function isTerminalType(type: string): boolean {
return type === BEHAVIOR_START || type === BEHAVIOR_END;
}
export function isTerminalNode(node: GraphNode): boolean {
return isTerminalType(node.type);
}
/** A tagged kind is one the value cannot show, so its port carries the field that edits it. */
export function portDefOf(port: DeclaredPort): PortDef {
const def: PortDef = { key: port.key, label: port.key, type: declaredPortType(port.kind) };
return isTaggedKind(port.kind) ? { ...def, field: flatDef(port.key, port.kind) } : def;
}
/** The ports the start (or end) node of `graph` declares, as seen from a node calling it. */
export function declaredPorts(graph: Graph | undefined, type: string): PortDef[] {
const node = graph && terminalNode(graph, type);
return (node?.ports ?? []).map(portDefOf);
}
/**
* The node definition as it applies to *this* node: identical to the registered one, unless the
* type declares ports per node (`declaresPorts`) or computes them (`derivePorts`).
*/
export function resolveDef(node: GraphNode, graph: Graph, lookup: GraphLookup): NodeDef | undefined {
return shapedDef(node, graph, lookup, true);
}
/**
* `inherit` is off while answering what feeds a shared group: a node of that kind then reports the
* `any` it was registered with, so two of them in a row cannot ask each other in circles (#207).
*/
function shapedDef(
node: GraphNode,
graph: Graph,
lookup: GraphLookup,
inherit: boolean,
): NodeDef | undefined {
const def = nodeDef(node.type);
if (!def) return undefined;
const shared = inherit ? def.sharedType : undefined;
if (!def.declaresPorts && !def.derivePorts)
return shared ? withSharedType(def, shared, node, graph, lookup) : def;
const own = (side: 'inputs' | 'outputs') =>
declaredOn(def, node.ports ?? [], side).map((p) =>
def.declaredPort ? def.declaredPort(p, node) : portDefOf(p),
);
const grown = def.derivePorts?.({ node, graph, lookup }) ?? {};
const side = (key: 'inputs' | 'outputs') => execFirst([...def[key], ...(grown[key] ?? []), ...own(key)]);
const resolved = {
...def,
label: grown.label ?? def.label,
inputs: side('inputs'),
outputs: side('outputs'),
};
return shared ? withSharedType(resolved, shared, node, graph, lookup) : resolved;
}
/** The group's outputs, retyped to what its inputs agree on; `any` leaves the definition alone. */
function withSharedType(
def: NodeDef,
group: SharedPortGroup,
node: GraphNode,
graph: Graph,
lookup: GraphLookup,
): NodeDef {
const type = agreedType(group.inputs.map((key) => feedingType(node, key, graph, lookup, false)));
if (type === 'any') return def;
return {
...def,
outputs: def.outputs.map((p) => (group.outputs.includes(p.key) ? { ...p, type } : p)),
};
}
/**
* What the edge into that input carries, or undefined while nothing is connected to it. `inherit`
* says whether a shared group on the *feeding* node may have its say: off while a group asks what
* feeds it, on when only the drawn colour is wanted, which is what the edge itself is drawn in.
*/
function feedingType(
node: GraphNode,
key: string,
graph: Graph,
lookup: GraphLookup,
inherit: boolean,
): PortType | undefined {
const edge = edgesInto(graph, node.id, key)[0];
if (!edge) return undefined;
const from = findNode(graph, edge.from.node);
const def = from && shapedDef(from, graph, lookup, inherit);
return def?.outputs.find((p) => p.key === edge.from.port)?.type;
}
/**
* `any` inputs painted as what flows into them: an unconnected one stays grey, a connected one takes
* the colour of its own edge, so a group feeding two different types is visible as two colours.
* Only `paintType` is set – the port's `type` stays `any`, so `canConnect` keeps taking everything.
*/
function paintedInputs(node: GraphNode, graph: Graph, def: NodeDef, lookup: GraphLookup): PortDef[] | null {
if (!def.inputs.some((port) => port.type === 'any' && !port.ghost)) return null;
return def.inputs.map((port) => {
if (port.type !== 'any' || port.ghost) return port;
const fed = feedingType(node, port.key, graph, lookup, true);
return fed === undefined || fed === 'any' || fed === 'exec' ? port : { ...port, paintType: fed };
});
}
/** A derived exec pin belongs at the top, above the fixed data ports too. */
function execFirst(ports: PortDef[]): PortDef[] {
return [...ports.filter((p) => p.type === 'exec'), ...ports.filter((p) => p.type !== 'exec')];
}
/** One end of an edge naming a key its node no longer has. */
interface GhostEnd {
edge: GraphEdge;
key: string;
isOutput: boolean;
}
/** Read from the edge list, not from the ports: what is looked for is exactly what has no port. */
function ghostEnds(node: GraphNode, graph: Graph, def: NodeDef): GhostEnd[] {
const inputs = new Set(def.inputs.map((p) => p.key));
const outputs = new Set(def.outputs.map((p) => p.key));
const ends: GhostEnd[] = [];
for (const edge of graph.edges) {
if (edge.to.node === node.id && !inputs.has(edge.to.port))
ends.push({ edge, key: edge.to.port, isOutput: false });
if (edge.from.node === node.id && !outputs.has(edge.from.port))
ends.push({ edge, key: edge.from.port, isOutput: true });
}
return ends;
}
/** `any` because the type the key once had is exactly what is no longer known. */
function ghostPort(key: string): PortDef {
return { key, label: key, type: 'any', inline: false, ghost: true };
}
/**
* The definition as the canvas draws it: the real ports with their pin colours (`paintedInputs`),
* then the keys only edges still name. The ghosts go last and skip `execFirst`, so no real row moves
* because of one – and none of this reaches `resolveDef`, which the interpreter, the compilers and
* `ConnectCommand` read as the truth.
*/
export function drawnDef(node: GraphNode, graph: Graph, def: NodeDef, lookup: GraphLookup): NodeDef {
const painted = paintedInputs(node, graph, def, lookup);
const ends = ghostEnds(node, graph, def);
if (ends.length === 0) return painted ? { ...def, inputs: painted } : def;
const side = (isOutput: boolean) =>
[...new Set(ends.filter((e) => e.isOutput === isOutput).map((e) => e.key))].map(ghostPort);
return {
...def,
inputs: [...(painted ?? def.inputs), ...side(false)],
outputs: [...def.outputs, ...side(true)],
};
}
/** Why a node warns although its own settings are sound: edges left hanging on keys that are gone. */
export function ghostProblem(node: GraphNode, graph: Graph, def: NodeDef): string | null {
const count = ghostEnds(node, graph, def).length;
if (count === 0) return null;
return count === 1 ? '1 edge on a port that is gone' : `${count} edges on ports that are gone`;
}
/**
* Why this call cannot do anything, or null if it can. A call is the one node that depends on a
* *different* graph, so it is the one node that can look perfectly healthy and still be dead.
*/
export function callProblem(node: GraphNode, lookup: GraphLookup, ownerId = ''): string | null {
if (node.type !== RUN_BEHAVIOR) return null;
const id = textOf(node.params[BEHAVIOR_PARAM] ?? '');
if (!id) return 'No behavior picked';
if (id === ownerId) return 'A behavior cannot run itself';
const program = lookup.behavior(id);
if (!program) return 'That behavior is gone';
if (!terminalNode(program.graph, BEHAVIOR_START)) return 'No start node – does nothing';
return null;
}
/**
* Everything that changes how a node looks, as one string. Views and the inspector rebuild when it
* changes – a port list that is derived rather than fixed has no other way of being noticed.
*/
export function portSignature(node: GraphNode, graph: Graph, lookup: GraphLookup, ownerId = ''): string {
const def = resolveDef(node, graph, lookup);
if (!def) return 'missing';
const list = (ports: PortDef[]) => ports.map((p) => `${p.key}:${p.type}`).join(',');
return `${node.type}|${def.label}|${list(def.inputs)}|${list(def.outputs)}|${
callProblem(node, lookup, ownerId) ?? ''
}`;
}