Files
feuerwerk/tools/e2e/14-overflow.mjs
T
DeveloperandClaude Opus 5 f83c568999
game-maker / suite (push) Successful in 9m18s
Tab row: what does not fit goes behind a menu, the active tab always stays (#84)
Nine tabs need 631 px; at 1280x800 the centre column offers 666 px, so the tenth
tab would have spilled under the inspector - the same overflow CI caught in run 5.

TabStrip replaces the bare HStack: it fits the longest prefix that stays inside
the budget, always appends the active tab, and offers the rest behind a fixed
28 px button. The button's width is fixed on purpose - deriving it from the
number of hidden tabs would make width depend on the count and the count on the
width.

The rule itself is a pure function (tabRow.ts), so it is checked without a
browser. setActive() calls relayout() itself because Widget.resize only lays out
on a changed size, and switching tabs does not change any size.

Adding a tab now needs no space arithmetic - only a line in TAB_ORDER,
TAB_LABELS and panes, all three Record<CentreTab, ...>, so forgetting one is a
type error.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-13 22:06:46 +02:00

175 lines
6.8 KiB
JavaScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* Labels must be shortened to fit their control, not written past it. Runs last because it renames
* assets to absurd lengths to provoke the case.
*/
/** A name far wider than any 200 px picker, so a control that does not truncate must spill. */
const LONG_NAME = 'Player movement with jumping and coyote time';
/** What the tab buttons read, to find one in the overflow menu. */
const LABELS = {
scene: 'Scene',
game: 'Game',
graph: 'Behavior',
statemachine: 'State machine',
shader: 'Shader',
texture: 'Texture',
animation: 'Animation',
container: 'Container',
list: 'List',
};
export async function overflow(t) {
const { check, sleep, json, evaluate, shot, mutate, drag, clickText } = t;
const pickerWidths = async () => {
const out = {};
for (const tab of ['graph', 'texture', 'container']) {
await evaluate(`__gm.showTab(${JSON.stringify(tab)})`);
await sleep(300);
out[tab] = await json(`__gm.${tab}.pickerWidth()`);
}
return out;
};
const before = await pickerWidths();
await mutate(`
for (const asset of __gm.state.project.assets) {
if (asset.type === 'behavior' || asset.type === 'texture' || asset.type === 'container')
asset.name = ${JSON.stringify(LONG_NAME)};
}
__gm.state.select(null)`);
await sleep(600);
// 14a. The pickers keep the width they were given instead of growing with the name they show.
const after = await pickerWidths();
for (const tab of ['graph', 'texture', 'container']) {
check(
`the ${tab} picker keeps its width when the name gets long`,
before[tab] === 200 && after[tab] === 200,
`before ${before[tab]}, after ${after[tab]}`,
);
}
// 14b. The tab row itself: a button past the centre column's edge sits under the inspector, and
// a click on it lands there (nine tabs on a 90 px floor did exactly that at 1280 px wide).
await evaluate("__gm.showTab('scene')");
await sleep(300);
const columnRight = async () => {
const column = await json('__gm.viewportRect()');
return column.x + column.w;
};
const spillOf = (row, right) => row.shown.filter((b) => b.right > right);
const wide = await json('__gm.tabRow()');
check(
'every tab button ends inside the centre column',
spillOf(wide, await columnRight()).length === 0 && wide.hidden.length === 0,
JSON.stringify({ spilled: spillOf(wide, await columnRight()), hidden: wide.hidden }),
);
// 14b-ii. Narrowed until the row cannot hold nine tabs, the leftovers go behind the overflow
// button instead of under the inspector – the guard against the tenth tab (#84).
const widenPanels = async (by) => {
const bars = await json('__gm.panelSplitters()');
await drag(bars.left.x, bars.left.y, bars.left.x + by, bars.left.y, { steps: 8 });
const after = await json('__gm.panelSplitters()');
await drag(after.right.x, after.right.y, after.right.x - by, after.right.y, { steps: 8 });
await sleep(300);
};
await widenPanels(250);
const narrow = await json('__gm.tabRow()');
const narrowRight = await columnRight();
check(
'a row too narrow for its tabs puts the leftovers away instead of past the edge',
narrow.hidden.length > 0 && spillOf(narrow, narrowRight).length === 0,
JSON.stringify({ hidden: narrow.hidden, spilled: spillOf(narrow, narrowRight) }),
);
check(
'the tab being edited stays in the row',
narrow.shown.some((b) => b.tab === 'scene'),
JSON.stringify(narrow.shown.map((b) => b.tab)),
);
await shot('35-tab-overflow');
// The overflow button names them, and picking one brings it into the row.
const wanted = narrow.hidden[narrow.hidden.length - 1];
await clickText('»');
await sleep(400);
const offered = await json('__gm.overlayTexts()');
check(
'the overflow button offers every tab that had to go',
narrow.hidden.every((tab) => offered.includes(LABELS[tab])),
JSON.stringify({ offered, hidden: narrow.hidden }),
);
await clickText(LABELS[wanted]);
await sleep(400);
const picked = await json('__gm.tabRow()');
check(
`picking ${LABELS[wanted]} from the overflow menu opens it and puts it in the row`,
(await json('__gm.tab()')) === wanted && picked.shown.some((b) => b.tab === wanted),
JSON.stringify({ tab: await json('__gm.tab()'), shown: picked.shown.map((b) => b.tab) }),
);
await widenPanels(-250);
await evaluate("__gm.showTab('scene')");
await sleep(300);
const back = await json('__gm.tabRow()');
check(
'giving the room back brings every tab into the row',
back.hidden.length === 0 && spillOf(back, await columnRight()).length === 0,
JSON.stringify({ hidden: back.hidden }),
);
// 14c. Every tab, because each one owns a different set of controls.
for (const tab of ['scene', 'graph', 'texture', 'game', 'container', 'list']) {
await evaluate(`__gm.showTab(${JSON.stringify(tab)})`);
await sleep(400);
const spills = await json('__gm.textOverflows()');
check(
`no label is drawn past its control in the ${tab} tab`,
spills.length === 0,
JSON.stringify(spills),
);
}
// 14d. Shortened, not simply dropped: the value must still be readable and marked as cut.
await evaluate("__gm.showTab('graph')");
await sleep(400);
const shown = (await json('__gm.textOverflows(true)')).find((e) => e.text.startsWith('Player movement'));
check(
'a value too wide for its dropdown is cut with an ellipsis',
Boolean(shown) && shown.text.endsWith('…') && shown.text.length > 8,
JSON.stringify(shown),
);
await shot('36-long-labels');
// 14e. An inspector full of dropdowns – the parent row and the enum fields – with a selection
// whose asset name is now overlong too.
await evaluate("__gm.showTab('scene')");
await sleep(300);
await evaluate("__gm.state.select({ kind: 'object', objectId: 'otex' })");
await sleep(500);
const inspector = await json('__gm.textOverflows()');
check('no label spills in the inspector', inspector.length === 0, JSON.stringify(inspector));
// 14f. The other direction: a control narrow enough to swallow its whole label draws nothing
// at all, which the overflow walk cannot see – an empty text spills over no edge.
for (const tab of ['scene', 'graph', 'texture', 'container', 'list']) {
await evaluate(`__gm.showTab(${JSON.stringify(tab)})`);
await sleep(400);
const dropped = await json('__gm.labelsDropped()');
check(
`no button is left without its label in the ${tab} tab`,
dropped.length === 0,
JSON.stringify(dropped),
);
}
// The narrowest buttons in the editor sit on a behaviour's variable rows.
await evaluate("__gm.state.select({ kind: 'asset', assetId: 'mover' })");
await sleep(400);
const onVariables = await json('__gm.labelsDropped()');
check(
'the variable rows keep their buttons labelled',
onVariables.length === 0,
JSON.stringify(onVariables),
);
}