adminandClaude Opus 5.5
4c7861b5b8
Painting on the 60x60 map of a project with fifty objects dropped the editor to 20 to 39 fps. A profile of a brush stroke showed four causes, none of them the brush itself. - Each frame of a stroke previews the model. The asset and hierarchy panels then built every row anew, so every label became a new text and a new upload to the GPU. One run spent 46 % of the main thread in those uploads. ListView.setItems now keeps a row whose item draws the same (sameListItem) and builds only the rows that changed. - The brush drew the whole scene on every pointer event, on top of the preview. Now the preview draws what the stroke changed, once a frame. The rectangle tool asks for one drawing a frame for its box. - An animated tile made the view draw in the tick and the preview drew it again in the same frame. animate now asks just before the frame is drawn and stays out when the view was drawn since the tick began. - layoutSymbols ran on every drawing and costs up to the cube of the symbols. SymbolLayoutMemo keeps the spots while no anchor moves. - A painted cell made the map read every "x,y" key again, and once more for each of the eight neighbours of every cell. layerCells reads a layer once per content into an index by place. layerTiles and the blocking cells take their neighbours from there (neighboursIn). parseCellKey reads a key without split, with the same results. The test hook sceneRedraws counts how often the scene view was drawn. Not done: a painted cell still works out the tiles and blocking cells of the whole map again, so that part grows with the map. Tests: - Brush stroke on a copy of the project (stein2, Chrome): 20 to 39 fps before, 47.5 after, 55 to 57 without painting. Labels drawn again during the stroke 2012 before, none after. Scene drawings per frame 1.32 before, 1 after. - One painted cell, headless: 28 to 16 ms on 60x60, 109 to 49 ms on the same map doubled to 120x120. - frame-preview: 2 new, red with the old pointer redraw. - tilemap: 3 new (key reading, index, refresh), list-ping 1 new, symbol-layout 1 new. 5 single reversals turned each red. - e2e 39,40 (melektaus-atx): ALL PASSED, 107 checks (1 new, a fast stroke: 6 drawings in 6 frames, no label drawn again). With the row reuse and the pointer redraw reverted it fails: 24 drawings in 3 frames, and the panels draw their labels again. - Gate (melektaus-atx): CHECK EXIT 0, 260 files, 4038 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
58 lines
2.2 KiB
TypeScript
58 lines
2.2 KiB
TypeScript
/**
|
||
* A row lighting up where an asset is listed, without being selected (#221, Unity's ping). The row
|
||
* itself needs text measurement, which Node lacks – e2e 28l-ii looks at it in the browser.
|
||
*/
|
||
import { describe, expect, it } from 'vitest';
|
||
import { EditorState } from '../../src/editor/state';
|
||
import { type ListItem, PING_MS, pingAlpha, sameListItem } from '../../src/ui/widgets/ListView';
|
||
|
||
describe('pingAlpha', () => {
|
||
it('holds full for the first fifth, then fades to nothing at PING_MS', () => {
|
||
const full = pingAlpha(0);
|
||
expect(full).toBeGreaterThan(0);
|
||
expect(pingAlpha(PING_MS / 5)).toBe(full);
|
||
expect(pingAlpha(PING_MS * 0.6)).toBeCloseTo(full / 2);
|
||
expect(pingAlpha(PING_MS * 0.9)).toBeLessThan(pingAlpha(PING_MS * 0.6));
|
||
expect(pingAlpha(PING_MS)).toBe(0);
|
||
expect(pingAlpha(-1)).toBe(0);
|
||
});
|
||
});
|
||
|
||
describe('sameListItem (#347)', () => {
|
||
it('keeps a row only while everything it draws is the same', () => {
|
||
const row: ListItem = { id: 'a', label: 'Crate', hint: '2', depth: 1, icon: '<svg/>', marks: ['<m/>'] };
|
||
expect(sameListItem(row, { ...row, marks: ['<m/>'] })).toBe(true);
|
||
expect(
|
||
sameListItem({ id: 'a', label: 'Crate' }, { id: 'a', label: 'Crate', depth: 0, overridden: false }),
|
||
).toBe(true);
|
||
const changes: Partial<ListItem>[] = [
|
||
{ id: 'b' },
|
||
{ label: 'Box' },
|
||
{ hint: '3' },
|
||
{ depth: 2 },
|
||
{ expanded: true },
|
||
{ overridden: true },
|
||
{ icon: '<svg></svg>' },
|
||
{ iconAtEnd: true },
|
||
{ heading: true },
|
||
{ marks: [] },
|
||
{ marks: ['<n/>'] },
|
||
];
|
||
for (const change of changes) expect(sameListItem(row, { ...row, ...change })).toBe(false);
|
||
});
|
||
});
|
||
|
||
describe('EditorState.pingAsset', () => {
|
||
it('names the asset and tells the listeners, but leaves the selection alone', () => {
|
||
const state = new EditorState();
|
||
state.select({ kind: 'asset', assetId: 'sprite' });
|
||
const heard: string[] = [];
|
||
state.on('ping', () => heard.push(state.pingedAssetId ?? ''));
|
||
state.on('selection', () => heard.push('selection'));
|
||
state.on('open', () => heard.push('open'));
|
||
state.pingAsset('texture');
|
||
expect(heard).toEqual(['texture']);
|
||
expect(state.selection).toEqual({ kind: 'asset', assetId: 'sprite' });
|
||
});
|
||
});
|