adminandClaude Opus 5.5
3a52f2290f
Until now every sound went straight to the speakers. There was no point where all of them came together, so nothing could turn the music down against the effects, and a compressor or a shared echo over everything had nowhere to sit. The bus technique of #346 was there already, only the end of the chain was missing. - Bus asset (Audio): Volume, Sound FX and Into. Into is empty for the master and never offers the bus itself nor a bus that already goes into it. The list is worked out when the menu opens, so a change made meanwhile counts. A loop that is in a project anyway sends the buses on it into the master. - The master is no asset. Its volume and sound FX are two new rows under Master in Project settings, one undo step each. A project written before has 1 and none, which is how it sounded. - Sound, instrument, pattern and song have a row Bus, empty for the master. Play sound, Play note, Play pattern and Play song have an input bus: From the asset, Master or a bus. Inside a song or a pattern only the bus of the song or pattern counts. - Set bus volume (bus, volume, time, easing) and Bus volume. An empty bus is the master. The volume set holds for the whole run, across scenes, over that of the asset. GameRun resets it at start and end. Set sound FX parameters without a voice now reaches the sound FX of the bus picked in its new bus input. - SoundLibrary: the master is the bus "mix", each bus "mix:<id>". Every bus, the playing masters of #346 included, ends there, and only the master is heard. setMix sets them up once a context exists, so an editor nobody listened to opens no audio device. The same mix again changes nothing, which lets the editor hand it over on every change of the project. - The tabs play as the game does: Sound, Sound FX, Instrument, Pattern and Song tab through the bus of their asset and the master. - Pause game does nothing to the buses (the user's answer 4b). A game that wants quiet in its pause menu sets a bus volume itself. - Streaming long music files is #349, split off as asked. Finding on the way: the Into menu first worked from a list made when the inspector row was built. After another bus was sent into the open one, e2e 34 saw it still offered. It is now asked on open. The SoundLibrary tests expected voices to end at the destination. They now end in the master, which adds its input, level and pan to every wiring and two gains to every list. Those expectations are updated, nothing else in them changed. Tests: - Unit buses (new): 15 green. Ten counter-checks, each red on its own: loop check, bus picked, reset at run start, bus of Set sound FX parameters, master volume in the settings, and in SoundLibrary default into the master, voices into the master, run volume over the mix, no context before a play, a playing on its bus. - Unit sound-library: 90 green (5 new). Node catalog: 416 green (9 new cases). - e2e 34 (melektaus-atx): ALL PASSED, 75 checks (3 new). The voice of the Sound tab was heard on mix:<bus>, that bus into the other, that one at 0.5 into the master. Master volume 0.6 via the dialog, undo back to 1. - Gate (melektaus-atx): CHECK EXIT 0, 262 files, 4072 tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
73 lines
3.1 KiB
TypeScript
73 lines
3.1 KiB
TypeScript
import { MIDDLE_C } from '../../../instrument/notes';
|
||
import { heldTempo } from '../../../music/time';
|
||
import type { NodeDef } from '../../NodeRegistry';
|
||
import { asBoolean, asNumber, asString } from '../../values';
|
||
import { exec, num, playedBusPort, soundFxPort, withDefault } from '../shared';
|
||
import { fxParamsOf, tempoPort } from './PlaySound';
|
||
|
||
export const PlayNote: NodeDef = {
|
||
type: 'PlayNote',
|
||
label: 'Play note',
|
||
category: 'action',
|
||
description:
|
||
'Plays one note of an instrument asset. "note" is its number as MIDI counts it: 60 is C4, 61 C#4, 72 C5. "velocity" is how hard it is struck, 0 to 1 – it makes the note quieter and is handed to what the instrument does with it. "duration" is how many seconds until the note is released; at 0 it is held until a Stop sound ends it. A note belongs to this object like a sound and stops when the object is destroyed, unless "detached" is on. "params" takes values for the parameters of the instrument from an Instrument parameters node. "fx" sends the note through a sound FX on top of what the instrument does, "fx params" takes values for its parameters from a Sound FX parameters node – the two sets stay apart. "voice" is the number of this note, for Set sound FX parameters and Stop sound; 0 where the instrument plays nothing for it. "tempo" is what a Delay in the instrument synced to beats counts by, in quarter notes a minute. "bus" is the bus it is heard on; left empty, the one the instrument names.',
|
||
inputs: [
|
||
exec(),
|
||
{
|
||
key: 'instrument',
|
||
label: 'instrument',
|
||
type: 'string',
|
||
field: {
|
||
key: 'instrument',
|
||
label: 'Instrument',
|
||
kind: 'asset',
|
||
default: '',
|
||
assetTypes: ['instrument'],
|
||
},
|
||
},
|
||
{
|
||
key: 'note',
|
||
label: 'note',
|
||
type: 'number',
|
||
default: MIDDLE_C,
|
||
field: { key: 'note', label: 'Note', kind: 'number', default: MIDDLE_C, min: 0, max: 127, step: 1 },
|
||
},
|
||
withDefault(num('velocity'), 1),
|
||
withDefault(num('volume'), 1),
|
||
withDefault(num('duration'), 0),
|
||
{
|
||
key: 'detached',
|
||
label: 'detached',
|
||
type: 'boolean',
|
||
default: false,
|
||
field: { key: 'detached', label: 'Detached (outlives this object)', kind: 'boolean', default: false },
|
||
},
|
||
{ key: 'fxParams', label: 'params', type: 'fxparams' },
|
||
tempoPort(),
|
||
{ ...soundFxPort(), key: 'soundFx' },
|
||
{ key: 'soundFxParams', label: 'fx params', type: 'fxparams' },
|
||
playedBusPort(),
|
||
],
|
||
outputs: [exec(), num('voice')],
|
||
params: [],
|
||
run: (ctx, inputs) => {
|
||
const instrument = asString(inputs.instrument);
|
||
const voice = instrument
|
||
? ctx.playNote(
|
||
instrument,
|
||
asNumber(inputs.note),
|
||
asNumber(inputs.velocity),
|
||
asNumber(inputs.volume),
|
||
asNumber(inputs.duration),
|
||
asBoolean(inputs.detached),
|
||
fxParamsOf(inputs.fxParams),
|
||
heldTempo(asNumber(inputs.tempo)),
|
||
asString(inputs.soundFx),
|
||
fxParamsOf(inputs.soundFxParams),
|
||
asString(inputs.bus),
|
||
)
|
||
: 0;
|
||
return { next: 'exec', outputs: { voice } };
|
||
},
|
||
};
|