Files
feuerwerk/tools/e2e/46-topbar.mjs
T
adminandClaude Opus 5 60d0146bde The topbar is icons only: the leading Project dropdown, the Scene picker and the labelled Play/Pause buttons are gone and in their place stand five icon buttons - menu, undo, redo on the left, play and pause in the middle - while Notice, the save state, fps and the Account menu keep the right side; the Play button swaps its icon for a stop square while the project runs and Pause swaps for a second play sign while it is held (Button.setIcon()), and iconSpace() drops the gap between icon and label when a button has no label, which is what kept a 24 px icon button 3 px off its own centre; the menu carries New project, Open project..., a separator and Project settings..., where the picker (src/editor/OpenProjectDialog.ts) preselects the open project and marks it "open", opens on a double click and puts Delete on the left of Cancel and Open - it closes itself before it asks whether to delete, because two modals on top of each other would have left the question standing over a list it no longer speaks about - and the settings dialog (src/editor/ProjectSettingsDialog.ts) holds the name, the "Play starts" switch (Start scene / Active scene, a preference of this browser and so no command) and the collision layers from #152, which retires CollisionLayersDialog.ts and the "Collision layers..." entry; what Apply actually writes is the pure function settingsChanges(), so renaming and the layers are each their own undo step and each drop out when nothing differs; the Scene dropdown falls away without replacement, the active scene is switched by double clicking it in the Assets panel, which is the way that was there anyway; new module 46 runs last with 9 checks (no label left in the bar, the run buttons in edit mode, the four menu entries, the picker with the open project preselected, Cancel leaving the project standing, the settings dialog on the state of the project, renaming with undo and redo through the icon buttons) and it neither opens nor deletes a project, because that would pull the project out from under every earlier module; modules 8, 18 and 35 and the harness follow the new bar, 6 unit tests cover settingsChanges and 3 the icons (#183)
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-20 16:34:14 +02:00

118 lines
4.9 KiB
JavaScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* The top bar after its rework (#183): five icon buttons and no captions at all. What it used to
* spell out moved into the one menu – the project list into "Open project…", the project name and
* the start-scene switch into "Project settings…" next to the collision layers.
*
* Runs last, and on purpose: the project picker is opened here and left again with Cancel. Opening
* or deleting a project for real would pull the project out from under every step before this one.
*/
export async function topbar(t) {
const { check, json, has, shot, clickText, clickToolbar, typeText, press, sleep, waitUntil } = t;
await press('Escape');
// 46a. Nothing in the bar is written any more. The five words it used to carry are asked for as
// drawn text: the buttons are still there, only their captions are gone.
const captions = {
project: await has('Project'),
undo: await has('Undo'),
redo: await has('Redo'),
play: await has('Play'),
pause: await has('Pause'),
};
check(
'the top bar carries no captions any more – menu, undo, redo, play and pause are icons',
Object.values(captions).every((shown) => shown === false),
JSON.stringify(captions),
);
const buttons = await json('__gm.runButtons()');
check(
'in edit mode the run buttons offer play and nothing to pause',
buttons.play === 'play' &&
buttons.pause === 'pause' &&
buttons.playEnabled === true &&
buttons.pauseEnabled === false,
JSON.stringify(buttons),
);
await shot('46-topbar');
// 46b. The one menu. Four entries, and the separator between what opens a project and what
// changes the one that is open.
await clickToolbar('menu');
const rows = await json('__gm.menuRows()');
check(
'the menu button opens new project, the project picker and the project settings',
JSON.stringify(rows) === JSON.stringify(['New project', 'Open project…', null, 'Project settings…']),
JSON.stringify(rows),
);
// 46c. The picker lists what the account owns, with the open project picked, and Cancel leaves
// that project exactly where it was.
await clickText('Open project…');
// The picker fetches the list before it can open, so it is waited for rather than read at once.
await waitUntil('__gm.projectPicker() !== null', { label: 'the project picker opened' });
const picker = await json('__gm.projectPicker()');
const projectId = await json('__gm.state.project.id');
const projectName = await json('__gm.state.project.name');
check(
'"Open project…" lists the projects with the open one picked',
picker !== null && picker.picked === projectId && picker.names.includes(projectName),
JSON.stringify({ picker, projectId, projectName }),
);
await clickText('Cancel');
check(
'Cancel closes the picker and leaves the project loaded',
(await json('__gm.projectPicker()')) === null && (await json('__gm.state.project.id')) === projectId,
JSON.stringify({ picker: await json('__gm.projectPicker()'), id: await json('__gm.state.project.id') }),
);
// 46d. The settings dialog holds the name, the start-scene switch and the collision layers of
// #152 – the three things the bar itself used to carry.
await clickToolbar('menu');
await clickText('Project settings…');
const settings = await json('__gm.projectSettings()');
const layers = await json('__gm.collisionLayers()');
check(
'"Project settings…" opens on the project as it stands',
settings?.name === projectName &&
(settings.playFrom === 'start' || settings.playFrom === 'active') &&
JSON.stringify(layers.dialog) === JSON.stringify(layers.project),
JSON.stringify({ settings, layers }),
);
// 46e. Renaming through it, and the icon buttons undoing and redoing it. The name is read off the
// project rather than written down here: CI seeds the same project under a different name.
const nameField = await t.locate(projectName);
await t.doubleClick(nameField.x, nameField.y);
await press('a', { ctrl: true });
await typeText('Renamed by 46');
await press('Enter');
await clickText('Apply');
await sleep(200);
check(
'Apply renames the project',
(await json('__gm.state.project.name')) === 'Renamed by 46',
await json('__gm.state.project.name'),
);
await clickToolbar('undo');
await sleep(200);
const undone = await json('__gm.state.project.name');
await clickToolbar('redo');
await sleep(200);
const redone = await json('__gm.state.project.name');
check(
'the undo and redo buttons of the bar walk the rename back and forth',
undone === projectName && redone === 'Renamed by 46',
JSON.stringify({ undone, redone, was: projectName }),
);
// Back to the name the rest of the world knows it by.
await clickToolbar('undo');
await sleep(200);
check(
'the project is handed back under its own name',
(await json('__gm.state.project.name')) === projectName,
await json('__gm.state.project.name'),
);
await t.saved();
}