Files
feuerwerk/src/runtime/systems/behaviorContext.ts
T
adminandClaude Opus 5.5 7dd3ae1131
game-maker / gate (push) Successful in 3m19s
game-maker / suite (push) Failing after 11m41s
Tie two objects with a hinge, a spring, a rope or for good (#154)
Two bodies could not be connected: no door on a hinge, no lamp on
a rope, no wheel on an axle. This is the first step of the issue,
the four joints without a motor. The slider and the motors follow
in a second step under the same issue.

- Joint is a new asset type, placed as a child of the object it
  holds, like a collider or a rigidbody. "Add joint…" in the
  object menu makes one or places one the project has. An object
  takes as many as it needs.
- Where the joint sits is the point it holds its object at. A
  hinge and a fixed joint have that one point only. A spring and a
  rope end at a connected anchor on the other object, counted in
  that object's own units, or in the scene's without one.
- The rows follow the type: length, stiffness and damping for a
  spring, length for a rope, an angle limit for a hinge. Length 0
  takes the distance the two ends were placed at. The limit counts
  from how the two were placed.
- The connected object is an object reference in the schema of the
  type. Pasting, containers and removing treat it as they treat
  every reference since #258.
- shownFor is a new schema option: a row is shown while an enum of
  the same bag holds one of the named values.
- The object needs a rigidbody, its own or one further up. Without
  one the joint holds nothing and the console says so once.
- A connected object without a rigidbody is a moving anchor: the
  joint has a kinematic body of its own that follows it.
- A connected object destroyed while playing makes the joint let go
  with a hint. Removed in the editor the reference empties, so the
  joint holds on to the scene. The issue asked for "inactive" there.
- "Add joint" ties two objects while the game runs, from a joint
  asset as the template. Destroy on the joint lets go, there is no
  Break joint node. Destroy with keep children takes the joints
  along with the object.
- The scene view draws a line from each joint to what it holds on
  to and rings the held point. A selected spring or rope has a
  round handle on its far end, and dragging it is one undo step.
- Joints hold in Play only. The editor run simulates nothing
  (#148), and the inspector of a placed joint says so.
- Rapier counts a revolute joint's limits absolutely, not from the
  start, so the placed angle is added. Measured with a probe.
- The + menu has 25 types now and no longer fits under its button
  on a canvas 800 high. It scrolls there, and e2e 04 scrolls to
  the last entry instead of expecting it in view.

Tests:
- Gate on melektaus-atx for this state: 218 files, 3390 tests
  (3336 + 54), exit 0.
- e2e 1-16,24,39-46,51,52,57,58 on melektaus-atx: 831 checks, all
  pass. Module 41 alone: 25 checks (21 + 4).
- 54 new unit tests: 40 in joints.test.ts (rope, spring, pendulum,
  limit, fixed, the other end, the node, containers, paste), 6 for
  the line the scene view draws, 4 catalog cases of the node. The
  remaining 4 come from tests that make a case per asset type.
- Four new e2e checks in module 41: Add joint from the menu, the
  rope to the hook with its line and handle, dragging the handle
  with one undo, the bob hanging in Play next to one that falls.
- e2e 04, 40 and 46 count the new type in their lists.
- 21 of 22 unit counter-probes fail their tests. The other one is
  equivalent: Rapier ignores removing a joint that left with its
  body, the guard stays.
- Three browser counter-probes fail their checks (2, 1 and 2).
- One screenshot looked at: icon, line, handle and the rope rows.
- The e2e sum of 1691 is counted (1687 + 4, 1687 measured by CI
  on e066613). The full suite and the smokes did not run.
- Not seen in the browser: spring, hinge with limit and fixed
  joint, the node Add joint, a connected object that moves, joints
  inside a container, the released game. Unit tests cover them
  but the last. Limits under a mirrored parent are not handled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-02 21:43:12 +02:00

249 lines
10 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* What a behavior's graph reaches of the running game, as the `NodeContext` its nodes are handed:
* the world, the keyboard, collisions and rays, physics, sound, the clock and the shared values.
* Handles arriving from a graph are resolved to the world's entities here, so no node holds one.
*/
import type { EntityHandle, NodeContext, PhysicsControl, SharedState } from '../../core/graph';
import { keyName } from '../../core/keys';
import { collisionFilterOf } from '../../core/model/collisionLayers';
import type { Vec2 } from '../../core/model/Properties';
import { JOINT_CONNECTED_KEY } from '../../core/model/joint';
import { objectReference } from '../../core/model/objectRefs';
import { findAsset, findAssetOf, findScene, type Project } from '../../core/model/Project';
import { soundFileOf } from '../../core/model/sound';
import { resolveAssetProps } from '../../core/properties/resolve';
import { loopsOf, volumeOf } from '../../core/properties/sounds';
import type { Entity } from '../Entity';
import { PhysicsSystem } from '../physics/PhysicsSystem';
import type { World } from '../World';
import type { AudioSink } from './Audio';
import type { Instance } from './behaviorPulses';
import type { Input } from './Input';
import { bodyOf, type CollisionSource, layerHolderOf, NOT_BLOCKED } from './solids';
export interface TimeScaled {
scale: number;
}
/** What the running `BehaviorSystem` lends every context it makes. */
export interface ContextSources {
project: Project;
input: Input;
collisions: CollisionSource | null;
audio: AudioSink;
clock: TimeScaled | null;
shared: SharedState;
/** A graph moved one of this instance's machines; its events follow between exec flows. */
stateChanged(machineId: string, from: string, to: string): void;
}
const NO_DYNAMIC_BODY =
'has no dynamic rigidbody, so Apply force, Apply impulse and Set velocity do nothing on it.';
export function behaviorContext(
instance: Instance,
world: World,
dt: number,
run: ContextSources,
): NodeContext {
const { entity, states } = instance;
const { project, collisions, clock } = run;
// Handles arriving from the graph are the entities themselves, or test doubles with the same id.
const resolve = (handle: EntityHandle | null): Entity | undefined =>
handle ? world.entities.find((e) => e === handle || e.id === handle.id) : undefined;
return {
self: entity,
owner: entity.parent,
variables: instance.variables ?? entity.props,
states,
shared: run.shared,
stateChanged: (machineId, from, to) => run.stateChanged(machineId, from, to),
time: world.time,
dt,
findByName: (name) => world.findByName(name) ?? null,
// By identity, not by id: a restarted scene builds new entities under the same ids.
isAlive: (target) => world.entities.some((e) => e === target),
findReferenced: (from, ref) => {
const found = resolve(from);
return (found && world.findReferenced(found, ref)) ?? null;
},
childByName: (parent, name) => {
const found = resolve(parent);
return (found && world.childByName(found, name)) ?? null;
},
objects: () => world.entities,
isKeyDown: (key) => run.input.isDown(key),
wasKeyPressed: (key) => run.input.justPressed.has(keyName(key)),
wasKeyReleased: (key) => run.input.justReleased.has(keyName(key)),
pointer: world.pointer,
hitTest: (target, x, y) => {
const found = resolve(target);
return Boolean(found && world.hitTest(found, x, y));
},
isTouching: (a, b) => {
const ea = resolve(a);
const eb = resolve(b);
return Boolean(collisions && ea && eb && collisions.touching(world, ea, eb));
},
moveAndSlide: (target, dx, dy) => {
const found = resolve(target);
if (!found) return NOT_BLOCKED;
if (collisions) return collisions.moveAndSlide(world, found, dx, dy);
found.x += dx;
found.y += dy;
return NOT_BLOCKED;
},
raycast: (from, direction, length, { ignore, triggers, layers }) => {
const hit = collisions?.raycast(world, from, direction, length, {
ignore: resolve(ignore) ?? null,
triggers,
layers,
});
world.noteRay(from, hit?.point ?? pointAlong(from, direction, length), Boolean(hit));
return hit ? { ...hit, object: bodyOf(hit.collider) } : null;
},
raycastAll: (from, direction, length, { ignore, triggers, layers, maxHits }) => {
const hits =
collisions?.raycastAll(
world,
from,
direction,
length,
{ ignore: resolve(ignore) ?? null, triggers, layers },
maxHits,
) ?? [];
// Drawn to the last thing it met, not to the first: that is how far this ray looked.
const last = hits[hits.length - 1];
const end = last ? last.point : pointAlong(from, direction, length);
world.noteRay(from, end, hits.length > 0);
return hits.map((hit) => ({ ...hit, object: bodyOf(hit.collider) }));
},
collisionLayerOf: (target) => {
const found = resolve(target);
const holder = found && layerHolderOf(world, found);
return holder ? collisionFilterOf(holder.props).layer : null;
},
ignoreOneWay: (target, seconds) => {
const found = resolve(target);
if (found) world.ignoreOneWay(found, seconds);
},
isTilemap: (target) => {
const found = resolve(target);
return found ? world.isTilemap(found) : false;
},
tileAt: (target, layer, cell) => {
const found = resolve(target);
return found ? world.tileAt(found, layer, cell) : null;
},
setTile: (target, layer, cell, tileId) => {
const found = resolve(target);
return found ? world.setTile(found, layer, cell, tileId) : false;
},
physics: collisions instanceof PhysicsSystem ? physicsControl(world, collisions, resolve) : undefined,
log: (message) => {
world.log.push(message);
// The `Log` node's whole purpose: the author wants this in the browser console.
// eslint-disable-next-line no-console
console.log(`[behavior ${entity.name}]`, message);
},
playSound: (assetId, volume, loop, detached) =>
playSound(run, assetId, volume, loop, detached ? '' : entity.id),
// An id nothing resolves stops nothing, rather than silencing the whole run by accident;
// only the empty id means "everything", which is what the node promises.
stopSound: (assetId) => {
const file = assetId === '' ? '' : soundFileOf(project, assetId);
if (assetId === '' || file) run.audio.stop(file);
},
spawn: (assetId, position, parent) => world.spawn(assetId, position, resolve(parent) ?? null),
addJoint: (assetId, owner, connected, at) => {
const on = resolve(owner);
if (!on || findAsset(project, assetId)?.type !== 'joint') return null;
const joint = world.spawn(assetId, { ...at, z: 0 }, on);
const to = resolve(connected);
// By id, as a pick in the inspector stores it: the scene view of the run then draws the link too.
if (joint && to) joint.props[JOINT_CONNECTED_KEY] = objectReference(to.objectId);
return joint;
},
destroy: (target, keepChildren) => {
const found = resolve(target);
if (!found) return [];
if (keepChildren) return world.removeKeepingChildren(found);
world.remove(found);
return [];
},
loadScene: (sceneId) => {
// An id naming no scene is dropped here rather than half way through the swap, where the
// run would already have torn down the world it is still standing in.
if (findScene(project, sceneId)) world.loadSceneRequested = sceneId;
else world.log.push(`Load scene: no scene ${sceneId}`);
},
stop: () => {
world.stopRequested = true;
},
restart: () => {
world.restartRequested = true;
},
timeScale: () => clock?.scale ?? 1,
setTimeScale: (scale) => {
if (clock) clock.scale = scale;
else world.log.push(`Set time scale is ignored in the editor run (${scale})`);
},
isPaused: () => world.paused,
setPaused: (paused) => {
world.paused = paused;
},
};
}
/**
* What the graph asked for, as the sink understands it: the asset's own volume scaled by the
* node's, and its loop flag unless the node overrules it either way. The asset is what a sound
* *is* – a node that says nothing therefore plays it as the project describes it.
*/
function playSound(
{ project, audio }: ContextSources,
assetId: string,
volume: number,
loop: boolean | undefined,
owner: string,
): void {
const asset = findAssetOf(project, assetId, 'sound');
if (!asset?.file) return;
const props = resolveAssetProps(project, asset);
const level = Math.max(0, Math.min(1, volumeOf(props) * volume));
audio.play(asset.file, level, loop ?? loopsOf(props), owner);
}
/** Where a ray of that length ends; where it has no direction, where it starts. */
function pointAlong(from: Vec2, direction: Vec2, length: number): Vec2 {
const d = Math.hypot(direction.x, direction.y);
if (!(d > 0) || !(length > 0)) return from;
return { x: from.x + (direction.x / d) * length, y: from.y + (direction.y / d) * length };
}
/** The physics nodes' way into the played game's engine, with the handles of the graph resolved. */
function physicsControl(
world: World,
physics: PhysicsSystem,
resolve: (handle: EntityHandle | null) => Entity | undefined,
): PhysicsControl {
const act = (handle: EntityHandle, action: (entity: Entity) => boolean): boolean => {
const found = resolve(handle);
if (!found) return false;
if (action(found)) return true;
physics.hint(world, found, NO_DYNAMIC_BODY);
return false;
};
return {
velocityOf: (handle) => {
const found = resolve(handle);
const v = found ? physics.velocityOf(found) : null;
return found && v ? { ...v, angular: physics.angularVelocityOf(found) ?? 0 } : null;
},
setVelocity: (handle, x, y) => act(handle, (e) => physics.setVelocity(e, { x, y })),
setAngularVelocity: (handle, degrees) => act(handle, (e) => physics.setAngularVelocity(e, degrees)),
applyImpulse: (handle, x, y) => act(handle, (e) => physics.applyImpulse(e, { x, y })),
setGravity: (x, y) => physics.setGravity(world, { x, y }),
};
}