meleki/feuerwerk
1
0 Fork 0
Code Issues 38 Actions Projects 1 Wiki Activity

Plugin support: Plugin hochladen #116

New Issue
Open
opened 2026-09-17 17:57:04 +02:00 by meleki · 0 comments
meleki commented 2026-09-17 17:57:04 +02:00
Owner
Copy link
Copy source

Aus #113: v1 legt Plugins von Hand nach data/plugins/. Später soll man eine .js-Datei im Editor hochladen können.

Zu bauen:

  • Upload unter Settings → Plugins (#114), Route POST plugins in api/index.php.
  • Prüfen: Endung .js, Größenlimit, Datei lässt sich als Modul laden und hat meta mit id und api.
  • Gleiche id wie ein vorhandenes Plugin → ersetzen (mit Rückfrage).
  • Plugin entfernen.

Abhängig von: #114 (Liste und Aktivieren) und #115 – vorher nicht bauen.

Aus #113: v1 legt Plugins von Hand nach `data/plugins/`. Später soll man eine `.js`-Datei im Editor hochladen können. **Zu bauen:** - Upload unter *Settings → Plugins* (#114), Route `POST plugins` in `api/index.php`. - Prüfen: Endung `.js`, Größenlimit, Datei lässt sich als Modul laden und hat `meta` mit `id` und `api`. - Gleiche `id` wie ein vorhandenes Plugin → ersetzen (mit Rückfrage). - Plugin entfernen. **Abhängig von:** #114 (Liste und Aktivieren) und #115 – vorher nicht bauen.
meleki added the held-back label 2026-09-17 17:57:04 +02:00
admin added this to the Development project 2026-09-17 18:32:35 +02:00
admin added low-priority and removed held-back labels 2026-09-17 19:17:06 +02:00
meleki referenced this issue from a commit 2026-09-20 14:24:29 +02:00
Plugins belong to the project, and they load before it: the project file gained the field plugins: ["demo-plugin.js"] (default empty, no formatVersion bump), the Plugins tab's switch writes into it as an ordinary undo step (SetPluginActiveCommand) instead of into a server-wide plugins.json, and the start order is turned around - startPlugins only fetches the list of files, then editor.boot() runs and ProjectStore.load(id, prepare) hands the raw JSON through before it is deserialized, where pluginsOf(raw) reads the list and PluginManager.syncTo() activates exactly those; that is the point of the issue, because what a plugin registers has to stand there before normalizeGraph would throw it away as unknown (#126, #127), a project switch first stops what the new project does not name and then starts what it does, a file the server does not have is passed over silently, and after signing out the manager is dead so a late event cannot start anything in a torn-down session; on the server plugins.json, PluginStore::setActive, isActive, the route PUT ?r=plugins/{file} and the 403 for inactive modules are gone and GET ?r=plugins only answers {file,bytes,updatedAt}, which makes every plugin file fetchable - the consequence accepted in #117, written down in the wiki for #115 and #116; publishPlugins(root) only copies files now, the seeder switches the demo plugin on in the fixture project, and the Plugins tab carries a puzzle piece as its icon while only a plugin's own tab still goes without one (the knob and the socket are cubic curves, not arcs, which Pixi's parser draws as a spike after an L); 3 new e2e checks in module 38 and 5 new unit tests cover the project as the owner of the switch, its undo, the order, pluginsOf against crude input and an unknown file name (#119)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
held-back
high-priority
low-priority
new
particles
question
shader
Shader-Assets, Shader-Graph, Filter
 state-machine
State machine follow-ups (from #51)
 todo-note
Aus dem alten todo-notes/-Ordner übernommen
No labels low-priority
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Development
Queue
Assignees
Clear assignees
meleki
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: meleki/feuerwerk#116