admin and Claude Opus 5.5
a295d233ed
Give sounds, instruments, patterns and songs a sound FX ( #352 )
...
A sound FX could only be picked where something was played: on a Play
node, a track or an item of a song. A sound that should always sound
through the same effect needed that pick everywhere it was used. Now
the asset says it once, and every place that plays it follows.
- New row Sound FX on a sound, an instrument, a pattern and a song,
right before Bus. A sound goes through it on every voice, an
instrument on every note after its graph, a pattern on all its
notes together and a song on its output.
- The fx input of Play sound, Play note, Play pattern and Play song
and the Sound FX of a song item now read "From the asset" while
empty. None is a pick of its own, stored as `#none` like `#master`.
A pick replaces the FX of the asset, it does not come on top.
- A pattern item's Instrument reads "From the asset" instead of None.
The meaning is unchanged.
- A double-click on a sound item opens the sound, as one on a pattern
item opens the pattern.
- The tabs play through the FX of their asset. The Pattern and Song
tab put it on a bus of their own between the output and the bus of
the asset. The keys of the Pattern tab play there too.
- Notes of a pattern or song go through the FX of their instrument.
Its chain is loaded with the other needs of the sequence.
Decided without asking:
- Old items and Play nodes with an empty fx now mean "From the
asset". No asset has an FX yet, so nothing sounds different.
- The label is "From the asset" as on Loop and Bus, not "From asset".
- A sound used as a Sample, as the impulse of a Reverb or as the test
sound of the Sound FX tab plays without its own FX.
Findings:
- In e2e, `__gm.inspectorField('Sound FX')` and `('Instrument')` find
the group of the Assets panel first. The check asks for the last
match.
Tests:
- Unit asset-fx (new): 8 green. Six counter-checks each turned red.
- Field lists of sound, pattern and song: Sound FX added.
- e2e 65 (melektaus-atx): ALL PASSED, 46 checks (3 new). Counter-check
without the FX bus of the tab: that check red.
- Gate (melektaus-atx): CHECK EXIT 0, 268 files, 4142 tests.
- Not checked: how it sounds, the Sound, Instrument and Pattern tab
in the browser.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com >
2026-10-07 22:02:26 +02:00
..
2026-10-03 21:01:10 +02:00
2026-09-23 13:59:04 +02:00
User management: signing in is required before anything is loaded, the sign-in screen is drawn in the same canvas (user name, password as bullets, Enter moves on and submits) and the editor is built only after it; the API gained auth/session, auth/login and auth/logout while every other route answers 401 without a session, projects carry an owner and a foreign one comes back as 404, accounts live in data/users.json with a password hash and sessions as files in data/sessions with a sliding 30 days, so a build under the open tab does not sign anybody out; Logout sits at the far right of the toolbar and, as asked in the issue, does not reload the page: Editor.dispose() takes the editor down while the canvas stays, which is why the autosave, the focus handlers, the window listeners of the tilemap panel, the shortcuts and the plugins all got a way back; the tools sign in as e2e (tools/lib/auth.mjs, password from GAME_MAKER_E2E_PASSWORD or the git-ignored data/e2e-password.txt) and the browser gets the same session by cookie, new e2e module 45 covers the screen, the wrong pair, the bullets, logout without a reload and signing in again, new unit tests for HttpAuthStore and for what a session leaves behind ( #177 )
2026-09-20 12:50:52 +02:00
2026-10-02 23:52:49 +02:00
2026-10-03 17:38:39 +02:00
2026-10-07 20:18:09 +02:00
2026-10-07 08:25:13 +02:00
2026-10-07 21:27:22 +02:00
2026-10-07 22:02:26 +02:00
2026-10-07 22:02:26 +02:00
2026-10-04 00:11:41 +02:00
2026-10-07 15:06:32 +02:00
2026-10-07 19:13:32 +02:00
2026-10-03 12:24:51 +02:00
2026-10-07 22:02:26 +02:00
2026-10-03 21:01:10 +02:00
2026-10-03 21:01:10 +02:00
2026-10-03 17:38:39 +02:00
2026-10-07 22:02:26 +02:00
2026-10-07 22:02:26 +02:00
2026-10-07 21:27:22 +02:00
2026-09-21 06:25:56 +02:00
2026-10-07 08:25:13 +02:00
2026-10-03 21:45:04 +02:00
2026-10-02 23:24:21 +02:00
2026-10-03 17:38:39 +02:00
2026-10-03 19:53:51 +02:00
2026-10-07 16:54:59 +02:00
2026-10-07 20:18:09 +02:00
2026-09-29 13:30:38 +02:00
2026-09-29 16:16:37 +02:00
2026-09-23 06:57:43 +02:00
2026-10-06 21:42:21 +02:00
User management: signing in is required before anything is loaded, the sign-in screen is drawn in the same canvas (user name, password as bullets, Enter moves on and submits) and the editor is built only after it; the API gained auth/session, auth/login and auth/logout while every other route answers 401 without a session, projects carry an owner and a foreign one comes back as 404, accounts live in data/users.json with a password hash and sessions as files in data/sessions with a sliding 30 days, so a build under the open tab does not sign anybody out; Logout sits at the far right of the toolbar and, as asked in the issue, does not reload the page: Editor.dispose() takes the editor down while the canvas stays, which is why the autosave, the focus handlers, the window listeners of the tilemap panel, the shortcuts and the plugins all got a way back; the tools sign in as e2e (tools/lib/auth.mjs, password from GAME_MAKER_E2E_PASSWORD or the git-ignored data/e2e-password.txt) and the browser gets the same session by cookie, new e2e module 45 covers the screen, the wrong pair, the bullets, logout without a reload and signing in again, new unit tests for HttpAuthStore and for what a session leaves behind ( #177 )
2026-09-20 12:50:52 +02:00
2026-10-03 17:09:53 +02:00
2026-10-07 21:27:22 +02:00
Tabs are open documents: Scene, Game and Plugins stay as fixed tabs, every other asset opens in its own tab (double click or Enter in the asset panel, on creation, from the list button), several assets of one kind can be open at once, a tab is labelled with its kind dimmed before the name, cut at 160 px and renamed with its asset, closes with its x or a middle click and goes away when its asset is deleted; a tab always shows its own document instead of following the selection, the picker in the tab head is gone, zoom and scroll are kept per document for the session and dropped on close, a double click on a call node stays in the same tab with breadcrumbs per tab; one editor per kind is switched between documents, the placement rules live in the pure module documents.ts, and the test hook showTab stays as a compatibility path; new e2e module 44 documents ( #171 )
2026-09-19 15:49:54 +02:00
2026-10-02 08:42:26 +02:00
2026-10-07 19:13:32 +02:00
2026-10-06 21:52:24 +02:00
2026-09-15 07:54:28 +02:00
2026-10-07 08:25:13 +02:00
2026-09-29 16:16:37 +02:00
2026-10-07 08:25:13 +02:00
2026-10-03 17:38:39 +02:00
2026-09-23 11:08:11 +02:00
2026-09-25 10:30:41 +02:00
2026-10-03 21:01:10 +02:00
2026-10-03 21:01:10 +02:00
2026-09-29 16:16:37 +02:00
2026-10-02 21:43:12 +02:00
2026-09-30 06:31:41 +02:00
Refactoring round 5 covers the code since round 4 without changing behaviour: four identical copies of dot() and three of "nearest point on a segment" stood in the collision math, in the hit area of the collider outlines and in the polygon handles, so they moved into the new module src/core/util/vec.ts; the warning line, the busy state, info() and the caret reset were written out line by line in both the sign-in screen and the password dialog and are now FormStatus; the closing row "Cancel plus a confirming button, optionally one on the left" was built by hand in FormDialog, FilePicker, OpenProjectDialog and PasswordDialog and is now dialogButtons(); the header bar was drawn by the toolbar, the TabHeader and the Breadcrumb each on its own and is now drawHeaderBar(); AddColliderCommand and AddRigidbodyCommand share a base, each subclass only builds its own asset; Editor.ts derives the panes from assetEditors instead of repeating eight entries and clamps its splitters with clamp(); jscpd over src falls from 0.19 % to 0.14 %; dead code is gone - listScenes() has been orphaned since the Scene picker fell away ( #183 ), DEFAULT_FILTER ( #152 ) was never used, the two test hooks projectPickerRowAt/rowPosition and particleCompiles are read by no tool, and four functions lost an export they did not need; seven comments that told history ("used to", "no longer", "since #...") describe the state of things now, and that this changed nothing was proved by a rebuild - the bundle is md5 identical, b4ad0dfe... before and after; the README said Logout sits at the far right of the toolbar, which has been the Account menu since #182 , and wiki/Architecture.md was missing src/core/util/ altogether; 4 new unit tests cover vec.ts, and switching the clamp on the segment off makes exactly one of them fail while none of the 76 neighbouring tests notice, so that clamping was covered nowhere before ( #85 )
2026-09-20 17:24:42 +02:00
2026-10-02 23:24:21 +02:00
2026-09-30 09:44:53 +02:00
2026-09-29 11:53:04 +02:00
2026-10-01 19:36:13 +02:00
2026-09-29 16:16:37 +02:00
2026-10-01 19:36:13 +02:00
2026-10-01 19:36:13 +02:00
2026-10-01 19:36:13 +02:00
2026-10-02 23:24:21 +02:00
2026-10-07 19:13:32 +02:00
2026-10-07 19:13:32 +02:00
2026-09-29 13:30:38 +02:00
2026-09-29 13:30:38 +02:00
2026-09-29 13:30:38 +02:00
2026-10-01 22:08:28 +02:00
2026-10-01 23:13:43 +02:00
2026-09-27 12:12:40 +02:00
2026-09-29 13:30:38 +02:00
2026-09-25 18:21:52 +02:00
2026-09-29 16:16:37 +02:00
2026-10-07 15:06:32 +02:00
2026-09-29 16:16:37 +02:00
2026-09-27 12:57:49 +02:00
Tabs are open documents: Scene, Game and Plugins stay as fixed tabs, every other asset opens in its own tab (double click or Enter in the asset panel, on creation, from the list button), several assets of one kind can be open at once, a tab is labelled with its kind dimmed before the name, cut at 160 px and renamed with its asset, closes with its x or a middle click and goes away when its asset is deleted; a tab always shows its own document instead of following the selection, the picker in the tab head is gone, zoom and scroll are kept per document for the session and dropped on close, a double click on a call node stays in the same tab with breadcrumbs per tab; one editor per kind is switched between documents, the placement rules live in the pure module documents.ts, and the test hook showTab stays as a compatibility path; new e2e module 44 documents ( #171 )
2026-09-19 15:49:54 +02:00
2026-10-02 12:02:57 +02:00
2026-10-07 17:59:08 +02:00
2026-09-29 16:16:37 +02:00
2026-10-03 21:01:10 +02:00