The small curve below the EQ node's rows (#375) only showed the bands.
Like the Compressor since #380, the node now shows the editor of its
tab between its inputs and its output, and is worked right there. A
double-click on the node still opens the same editor in a tab.
Two wishes for the nodes with a panel came on top and share the same
files, so they are in this commit as well: the numbers below the
Compressor's knobs read as plain labels (#382), and the wheel over a
node zooms the graph instead of turning a value (#383).
#381, the EQ in its node:
- EqPanel holds the curve, the band's numbers and the help line, taken
out of EqEditor. The tab puts its one panel under a header, each EQ
node has a panel of its own at 720 x 360 (EqFace).
- A press on the curve neither picks nor moves the node. A
double-click on the curve adds a band, one on the title or the edge
opens the tab.
- In the node a press on the Type or Slope button stays with the
button, so the node is not picked or moved.
- The spectrum runs in the node while it is in the picture. The tab
lets go of the tap once, like the Compressor's, and Editor.tick lets
every unseen tab and graph go before any seen one listens.
- The count of bands moved from the tab's header into the band row,
so the node shows it as well.
- The node picture of #375 is gone with its only user: NodePicture,
EQ_PICTURE and NodeView's drawing of it.
#382, the numbers below the Compressor's knobs in its node:
- A Knob with typed: false shows its number as a centred Label without
a box, in the panel's ink. The ratio reads 4:1 (ratioText).
- The label is as high as its text and sits up in the dial's open
bottom, right under the ends of the scale.
- Label takes a colour of its own.
#383, the wheel in a graph:
- GraphCanvas takes the wheel on the way down and stops it there. It
zooms over a node too, and no knob or curve in a node sees it.
- The tabs keep their wheel: a knob's step, a band's Q and the zoom
of the EQ's dB.
Found on the way:
- A Menu opened below a button in the zoomed graph would have been
placed by the button's own height. openBelow now takes the bottom
edge as drawn.
- The band row did not lay out its labels after a text change when
its own size stayed. In the tab a later resize hid it, in the node
"Band 1" and the count were missing. The row now lays out itself.
- Handle and point positions for the checks were unscaled. They now
go through toGlobal and hold at the graph's zoom.
Tests:
- Unit parametric-eq: 16 tests. The #375 tests now check
eqCurvePoints and eqRangeOf directly. compressor-view: ratioText.
- e2e 34 (atx): ALL PASSED, 125 checks (3 new: the EQ panel and its
ports, editing in the node, the spectrum in the node with the tab
open). The Compressor node's check reads its numbers as labels and
8:1. Both node checks now expect the wheel to zoom the graph and
leave the ratio, the Q and the dB zoom alone.
- The unseen-tab check now leaves for the Scene tab, since the node
in the graph listens to the same tap.
- Counter-check: the tab letting go of the tap every unseen frame
stalls the node's spectrum with the tab open (1 frame against 22,
probe on stein2).
- Gate (atx): CHECK EXIT 0, 283 files, 4357 tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adminandClaude Opus 5.5
79a04e6764