Round 12 of the clean-up. Duplicate code had grown from 33 clones
(249 lines) after round 11 to 140 clones (1263 lines), almost all of
it in the panels and faces of the sound FX devices (#379 to #401).
It is down to 57 clones (416 lines) now, and src is 816 lines
shorter.
- deviceParts.ts holds what the device panels built by hand: the
head, rows of knobs, the screen style and the row layout for
groups of knobs. Twelve panels use it. panel.knobs stays because
the debug hooks read it.
- DeviceFace is the base of the twelve faces. It finds the node and
does wired, preview, commit, set, hide, reload and audition.
compressorWired lives there as paramWired.
- TextPool replaces ten copies of "make texts as needed, hide the
rest" in the wave and video tabs, the rulers, the piano roll and
the song and composition timelines. clipStrip.ts is the clip label
strip the wave and video tabs share.
- core/util/bytes.ts has the concat that ogg, matroska and avcColour
each wrote out.
- Dead code is gone: clear on the video players (never called since
#402), posterFileOf and videoTimeAt (only tests called them) and
easeOut (the same as glide(t, 3)). Values only used in their own
file lose their export.
- Comments over 125 columns are wrapped, and comments that told the
history ("as before", "used to") say what is, in src and in the
e2e modules.
- Left alone on purpose: AnimationEditor and CompositionEditor share
only the play button, and the curve panels are built differently.
- Chip now places its boxes through put, which rounds. They were
whole numbers already. The three row layouts are byte-identical
before and after.
- README lists the video and composition assets and the Videos and
Compositions pages.
Tests:
- Gate (melektaus-atx): CHECK EXIT 0, 313 files, 4835 tests.
- e2e 25, 34, 64, 65, 66, 69 (melektaus-atx): ALL PASSED, 330 checks.
- TextPool without keeping its texts and framesToRoom without making
room both go red.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adminandClaude Opus 5.5
0701fe3856